Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to furniture bridges #56019

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Tweaks to furniture bridges #56019

merged 2 commits into from
Mar 11, 2022

Conversation

Night-Pryanik
Copy link
Contributor

Summary

Bugfixes "Tweaks to furniture bridges"

Purpose of change

Fix several bugs I noticed.

Describe the solution

  • Don't apply increased stamina burn when walking or waiting on "furniture bridges".
  • Don't apply slowing down when walking over "furniture bridges". Most bridges are supposed to be easy to move on, so I set base move cost of "furniture bridges" to 2 (like ordinary bridge terrain) + their move_cost_mod. At the time of writing our sole "furniture bridge" (scrap metal bridge) is indeed easy to move on, so its move_cost_mod is 0. In the future we might add more difficult to move versions of such bridges, like rope suspension bridges, with higher move_cost_mod.
    изображение

Describe alternatives you've considered

None.

Testing

Walked over scrap metal bridge. Checked stamina burn. Checked movement cost.

Additional context

None.

@Night-Pryanik Night-Pryanik added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Mar 11, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 11, 2022
@ZhilkinSerg ZhilkinSerg merged commit c705efd into CleverRaven:master Mar 11, 2022
@Night-Pryanik Night-Pryanik deleted the tweaks-to-furniture-bridges branch March 12, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants