Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't make player's feet wet when walking over scrap metal bridge #56005

Merged
merged 4 commits into from
Mar 11, 2022
Merged

Don't make player's feet wet when walking over scrap metal bridge #56005

merged 4 commits into from
Mar 11, 2022

Conversation

Night-Pryanik
Copy link
Contributor

Summary

Bugfixes "Don't make player's feet wet when walking over scrap metal bridge"

Purpose of change

Describe the solution

Added new BRIDGE flag to scrap metal bridge furniture and documentation for it.
Added checks for this new flag to code snippets related to drenching player.

Describe alternatives you've considered

Convert this bridge from furniture to terrain. Leaving it as a furniture opens various possibilities: in the future we might be able to construct this bridge between roofs of adjacent buildings, or construct it over some traps in order to avoid them etc.

Testing

Debug-spawned this bridge over the deep water. Teleported to the bridge. Walked and waited on the bridge. My feet were dry.

Additional context

None.

@Night-Pryanik Night-Pryanik added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Mar 10, 2022
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 10, 2022
@ZhilkinSerg ZhilkinSerg merged commit e93ba46 into CleverRaven:master Mar 11, 2022
@Night-Pryanik Night-Pryanik deleted the scrap-metal-bridge-is-actually-bridge branch March 11, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

My feet become wet when I walk on top of a scrap metal bridge
2 participants
@Night-Pryanik @ZhilkinSerg