Allow swapping positions and moving out of the way for all types of friendly NPCs #56000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Night-Pryanik
added
NPC / Factions
github-actions
bot
added
json-styled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Allow swapping positions and moving out of the way with all types of friendly NPCs"
Purpose of change
I suppose it's completely fine to ask a friendly NPC, even if he's not your ally, to swap positions and move him out of the way.
Describe the solution
Replaced check for being player ally to check for being friendly NPC.
Describe alternatives you've considered
None.
Testing
Found NPC with
MGOAL_GO_TO_TYPEtype of mission and with"effect": [ "follow_only" ]on start of it. Accepted his mission so he started to follow me (didn't become an ally). Interacted with him and checked if it's possible to swap positions with him and move him out of the way.Additional context
None.