Automatically post a warning comment when translation files are changed #55922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
json-styled
github-actions
bot
added
the
BasicBuildPassed
NetSysFire
added
Code: Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Once in a while people come up with a pull request that modifies the
.pofiles. These files are only supposed to be pulled from Transifex automatically and should not be modified in other PRs.Describe the solution
Add a github action that automatically detects translation file changes, and post a warning comment if a skip phrase
Translation file changes are intendedis not found in the PR body.The pull translation action is updated to include the skip phrase.
Describe alternatives you've considered
Explain in person everytime someone changes the files.
Testing
Qrox#7 triggers the warning by modifying a
.pofile. The comment is only posted once, but the action always fails.Qrox#6 does not trigger the warning by including the skip phrase. (The action results in that PR are from Qrox#7, probably because the two PRs are based on the same branch. The actual action result is here)