Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lemat → LeMat #55900

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Lemat → LeMat #55900

merged 1 commit into from
Mar 10, 2022

Conversation

Faalagorn
Copy link
Contributor

Summary

None

Purpose of change

Unify the name of LeMat revolver.

Describe the solution

Change Lemat to LeMat.

Describe alternatives you've considered

None.

Testing

Simple text change, spawn an item to see it.

Additional context

Fixes issue on Transifex. Already correct in other places.

@github-actions github-actions bot added Json astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 6, 2022
@Maleclypse Maleclypse added the <Bugfix> This is a fix for a bug (or closes open issue) label Mar 7, 2022
@Inglonias
Copy link
Contributor

I'm not sure how necessary it was to make a separate PR for each typo you found. I would encourage you to group these by file in the future, rather than making a separate PR for each individual typo.

@Faalagorn
Copy link
Contributor Author

I thought about it too, though I was cherry-picking the fixes from Transifex starting off with the easiest ones. I may indeed have gone a little over board at the end of the day, at least it makes River happy as she can merge a simple ones. :)

I also had bad experience with bigger changes not getting merged in the past, but that might be just a wrong prejudice from a past.

Finally, which I mentioned on Discord, initially I tried not touching more than one file out of the pure laziness of using GitHub web where you can only edit one file in commit (there are some that fix multiple issues in file, but at the end of the day I just "rushed" through some issues without realizing before that something else was to be fixed on a file).

But yeah, in future I'll try to make a bigger ones hopefully.

@Inglonias
Copy link
Contributor

GitHub has a built-in VSCode based editor you can use to edit more than one file at a time. Simply press "." when viewing your repo to invoke it.

@Faalagorn
Copy link
Contributor Author

Oh, I didn't know that, thanks @Inglonias !

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 9, 2022
@kevingranade kevingranade merged commit f34f3ac into CleverRaven:master Mar 10, 2022
@Faalagorn Faalagorn deleted the patch-37 branch March 10, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants