Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code for ammo requiring melee techniques #55820

Merged
merged 6 commits into from
Mar 9, 2022

Conversation

bombasticSlacks
Copy link
Contributor

@bombasticSlacks bombasticSlacks commented Mar 4, 2022

Summary

Features "Melee techniques can require and expend ammo"

Purpose of change

For the pulverizer I want to add in #55819, it runs on powder blanks. So I need to add support for it to expend them on use.

Describe the solution

This PR Does The Following:

  1. Adds powder blanks as an ammo type
  2. Adds the Pulverizer to the game as a debug example (though it will spawn with Frontier Guns From The Artisans #55819)
  3. Adds a new flag for techniques "needs_ammo" which means that the technique will only be selected if the weapon has ammo in it.
  4. When you activate the technique it expends ammo in the weapon.

Todo:

  • Get revolver like case ejection working
  • Maybe over engineer the code further (but I don't want to over-perscribe how this could be extended in the future)
  • Make blanks spawn/make the crafting recipe (this probably will get moved over to Frontier Guns From The Artisans #55819)

Describe alternatives you've considered

Using the gun code for this would have worked but would be janky since then your melee chance would be based off gunskills. Also I like the idea of having to really hit the crit to get it to pop.

Testing

Additional context

image

image

image

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 4, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 4, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 4, 2022
@Maleclypse Maleclypse added [C++] Changes (can be) made in C++. Previously named `Code` Melee Melee weapons, tactics, techniques, reach attack labels Mar 5, 2022
@github-actions github-actions bot added C++ Mods: Generic Guns Anything to do with Generic Guns labels Mar 5, 2022
@kevingranade kevingranade merged commit b41e49c into CleverRaven:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Melee Melee weapons, tactics, techniques, reach attack Mods: Generic Guns Anything to do with Generic Guns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants