-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added multiple camp construction workers #55816
Added multiple camp construction workers #55816
Conversation
There's probably something wrong with a support tool, as I received an Email referencing "Pull Request Labeler: No jobs were run" with the following (although no failures were indicated in the list of checks yet): Invalid workflow file: .github/workflows/labeler.yml#L12 Next support tool error: Apply Test Labels: labeling General build matrix / Basic Build and Test (Clang 6, Ubuntu, Curses) (pull_request): Not sure which "All tests passed" sections with backtraces resulted in "14:01:05.069 INFO : Treating result as failure due to error logged during tests. |
There is a bugfix the labeler in play. |
…into multiple_constructors
"Clang 12, Ubuntu, Tiles, ASan": failed due to some broken monster attack test:
|
…into multiple_constructors
Another win for the house in the test casino: "LGTM analysis: C/C++" timed out as usual. |
Summary
Features "Added multiple workers to camp construction"
Purpose of change
Allow players to assign multiple workers to camp construction missions.
Fix #53656
Describe the solution
When a camp construction job is started, ask for additional companions after the first one until out of companions or the player escapes out of the selection list. The time taken is divided by the number of companions assigned and only then converted to "work days".
When the work is done, all companions assigned to the construction is returned without any selection process (just like "normal" jobs don't ask for who to return when there's only one candidate).
When emergency recalling a companion and there there is at least one companion left working on a construction mission, sum up the remaining time and dividing it over the remaining companions (so they will have longer before they're done). The last one removed will drop the job completely as previously.
Describe alternatives you've considered
Testing
Assigning one and two companions to camp and expansion upgrade tasks and verifying that things behave as expected when finalizing and emergency recall companions.
Additional context
Expansion task selection. No change in functionality, but note the time (2 days, 6 hours):
Selection of a companion. Again, no change from the current functionality:
Selection of the other companion. The prompt text is different (and there's no abortion message when not selecting a additional companion):
The two companions are working on the construction: Note that there are two of them, and the time listed is half that of the original (single companion) time (but could be different due to work days conversions):
The same job one day later:
The same job after having emergency recalled one of the companions, with double the time remaining:
A different time line where nobody was emergency recalled, and two days have passed from the start:
Result when recalling the two companions from their completed task:
And after dismissing the previous popup the second companion is also announced: