Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appliance construction errors with debug hammerspace #55811

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

dseguin
Copy link
Member

@dseguin dseguin commented Mar 4, 2022

Summary

None

Purpose of change

#55632 (comment)

If the player has the Debug Hammerspace trait when placing an appliance through the construction menu, they'll be greeted to a couple of errors:

error1
error2

The resulting construction becomes a standing lamp by default:

debugmsg( "item %s used by construction is not base item of any appliance!", item_id.c_str() );
return vpart_ap_standing_lamp;

lamp

Describe the solution

If the player is placing an appliance using Debug Hammerspace, explicitly add the construction's components to the "used" items.

Describe alternatives you've considered

Just let it be. Debug mutations are debug mutations :P

Testing

Placing a solar panel with Debug Hammerspace:

traits
construct
solar_success

Additional context

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 4, 2022
@Maleclypse Maleclypse added <Bugfix> This is a fix for a bug (or closes open issue) Code: Debug Debugging and troubleshooting the game, also includes the debug menu labels Mar 4, 2022
@github-actions github-actions bot added the C++ label Mar 5, 2022
src/construction.cpp Outdated Show resolved Hide resolved
src/construction.cpp Outdated Show resolved Hide resolved
src/construction.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Mar 8, 2022
@kevingranade kevingranade merged commit 97843a3 into CleverRaven:master Mar 9, 2022
@dseguin dseguin deleted the fix_app_debug_hs branch March 9, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Debug Debugging and troubleshooting the game, also includes the debug menu json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants