Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Option to use Grass Sheets for Door Curtains #55792

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

Light-Wave
Copy link
Contributor

Summary

Content "Door Curtains from grass sheets"

Purpose of change

Mainly due to portal storms, it is important to be able to build doors to lock yourself indoors. If you do not have access to metalworking and/or cotton, this can be quite difficult. Allowing the player to use grass sheets instead of sheets should fix this.
Fixes #55789

Describe the solution

A new type of door that is like the curtain door but made from grass sheets. Deconstructs to grass sheets. Smashing might yield grass yarn. Can also be opened and closed by the portal storm opening and closing of doors.

Describe alternatives you've considered

The construct cost of the old sheet door seems a little strange when it comes to the string and the string substitutes. I considered to update it to match the grass sheet curtain recipe, but decided against it.

Testing

TBD

Additional context

TODO:

  • Test it
  • check spelling and grammar
  • Make sure I didn't miss to update any IDs

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 2, 2022
@Maleclypse Maleclypse added <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Mar 3, 2022
@kevingranade kevingranade merged commit 74dba6e into CleverRaven:master Mar 4, 2022
@Light-Wave Light-Wave deleted the grass_curtains branch March 28, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to use Grass Sheets for Door Curtains
3 participants