Partial update to martial arts and magic weapons #55756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional, expressive data to these weapons to make them more accessible when used in certain situations (i.e. martial arts). fixes CleverRaven#55717
Makes certain martial arts able to use more weapons. fixes CleverRaven#55717
Maleclypse
added
Martial Arts
github-actions
bot
added
the
astyled
Some changed JSON files were not properly linted.
|
Looks pretty good 👍, I might make some minor tweaks when(if) I eventually get around to deep diving into the weapon categories for each art individually. Not that I hold any authority over it or anything. |
github-actions
bot
added
json-styled
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixes bug where some some weapons would not work with some martial art styles"
Purpose of change
Addresses the issue #55717 where some weapons didn't work with some martial art style.
Describe the solution
Added
"copy-from"and"weapon_category"keys to some enchanted melee weaponry to make them more "general". Updated some martial arts to include categories that seemed to fit said martial arts. This results in some weapons that were previously unusable in some martial arts now usable.Describe alternatives you've considered
Not using
"copy-from", since it may disrupt the balance of a weapon, however I believe this shouldn't be an issue.Testing
Opened the game and tested some weapons against certain martial art styles to make sure they now worked. Used the example in #55717 as a base. This can be easily tested by just looking at the descriptions of certain weapons that fit the category in a martial art and seeing if can be used.
Additional context