Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds info about Holsters to the inventory UI #55755

Merged
merged 3 commits into from
Mar 4, 2022

Conversation

bombasticSlacks
Copy link
Contributor

Summary

Interface "Adds info about Holsters to the inventory UI"

Purpose of change

With all the new ablative pockets, and single item holding ripoff pockets and slots I and some other have been adding it may not be intuitive for new players. This should help make it clearer, or at least give the player more immediate info.

Describe the solution

Adds a new row to the Inventory UI that explains how many holsters you have, how many are in use, and how much of your remaining volume is "holsters" which are normally more selective pockets.

Describe alternatives you've considered

Waiting till after @KorGgenT stuff. I didn't realize I was writing something that iterated over worn until I was about halfway through ( I was copying and pasting other functions and modifying them). If this gets merged before your stuff (it shouldn't) I'll make a patch for your PR.

Testing

Loaded up the game, gave myself some pockets, can parse the info.

image

image

Additional context

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 28, 2022
@Maleclypse Maleclypse added Controls / Input Keyboard, mouse, keybindings, input UI, etc. [C++] Changes (can be) made in C++. Previously named `Code` labels Feb 28, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 1, 2022
@kevingranade kevingranade merged commit a6702c6 into CleverRaven:master Mar 4, 2022
@bombasticSlacks bombasticSlacks deleted the holster-details branch March 9, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Controls / Input Keyboard, mouse, keybindings, input UI, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants