Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dialog string variables #55380

Merged
merged 4 commits into from
Feb 19, 2022
Merged

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Feb 14, 2022

Summary

None

Purpose of change

Part of #53625
Fixes #55155
Add debug commands to set variables

Describe the solution

Add new functions to use variable access syntax to allow string variables of u, npc and global to be changed/tested.
Add tag parsing to message function so variables can be added to messages.
Shamelessly stole the str_or_var code from #55233

Describe alternatives you've considered

Testing

Used this json:

{
    "type": "effect_on_condition",
    "id": "test",
    "condition": { "compare_string":[{"global_val":"test_var", "default_str":"race"},"Test"] },
    "effect": [{ "u_message": "<global_val:tester> testtastic" },{"set_string_var":"fun", "target_var":{"global_val":"tester"}}]
  },

Additional context

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 14, 2022
@Maleclypse Maleclypse added <Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Effects / Skills / Stats Effects / Skills / Stats labels Feb 14, 2022
@Ramza13 Ramza13 force-pushed the string_vars branch 2 times, most recently from 61015b1 to b8eba2d Compare February 16, 2022 17:35
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 17, 2022
@kevingranade kevingranade merged commit 27ab2a5 into CleverRaven:master Feb 19, 2022
@Ramza13 Ramza13 deleted the string_vars branch February 19, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions Mechanics: Effects / Skills / Stats Effects / Skills / Stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a way to add non character variables (globals)
3 participants