Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR] Added a message notifying player about why he can't mine terrain/furniture with bash resistance above maximum mining ability for a pickaxe/jackhammer #55346

Merged
merged 5 commits into from
Mar 10, 2022

Conversation

Night-Pryanik
Copy link
Contributor

Summary

Interface "Added a message notifying player about why he can't mine terrain/furniture with bash resistance above maximum mining ability for a pickaxe/jackhammer."

Purpose of change

Describe the solution

Added a message notifying player about why he can't mine terrain/furniture with bash resistance above maximum mining ability for a pickaxe/jackhammer.
I took a value of 70 for maximum mining ability, as it's str_min for bashing a concrete wall. The value could be increased or decreased if it feels too high or low.

Describe alternatives you've considered

Make maximum mining ability for jackhammer a bit higher than for pickaxe. But I'm not sure if it makes sense.

Testing

Activated pickaxe, selected resin wall. Got usual You can't mine there. message and also new The material is so hard that you hardly can make even a dent.

Additional context

While skimming through various types of terrain in order to find a good candidate for a maximum mining ability, I noticed that we have reinforced concrete wall with a str_min value of 120. And despite its own description stating that only serious explosives and high-speed impacts would be capable of damaging this wall., it's still easily mineable by a ordinary pickaxe (i.e. has MINEABLE flag), which obviously isn't a serious explosive nor it's capable of making really high-speed impacts. Should I increase maximum mining ability to 120? Or should we remove possibility of mining reinforced concrete wall with a pickaxe?

Also I'm not sure why simple concrete wall has better bash protection than ordinary concrete wall (90 versus 70).

…iture with bash resistance above maximum mining ability for a pickaxe/jackhammer
@Night-Pryanik Night-Pryanik added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics labels Feb 13, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 13, 2022
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 13, 2022
src/iuse.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 14, 2022
@PatrikLundell
Copy link
Contributor

My amateur view is that "mining" a reinforced concrete wall should require additional tools to deal with the metal reinforcements. Thus, it ought to be penetrable with the right set of tools, but that set isn't just a pick axe analog. I would guess an oxytorch, angle grinder (if that exists in the game), or similar would be needed to deal with the reinforcements.

Also, I don't think it's reasonable for a jackhammer to be capable of dealing with things pick axes can't: the difference between them is speed and effort, both of which the game is currently incapable of modeling.

src/iuse.cpp Outdated Show resolved Hide resolved
src/iuse.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot removed astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 25, 2022
src/iuse.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 25, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 6, 2022
@kevingranade kevingranade merged commit 6621e88 into CleverRaven:master Mar 10, 2022
@Night-Pryanik Night-Pryanik deleted the notify-if-ter-furn-is-too-hard-for-mining branch March 10, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mi-go camp walls cannot be mined by pickaxe or jackhammer.
5 participants