Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soap bottle parity with plastic bottles #55296

Merged
merged 5 commits into from
Mar 3, 2022

Conversation

haveric
Copy link
Contributor

@haveric haveric commented Feb 11, 2022

Summary

Bugfixes "Soap bottle parity with plastic bottles"

Purpose of change

Fixes #53868

Describe the solution

  • Changed the name to "plastic soap bottle" to avoid name confusion.
  • Added "bottle_bathroom" to all recipes as an alternative to "bottle_plastic" using the same amount since they are near identical items.
  • Added a molding recipe matching the "bottle_plastic"

Describe alternatives you've considered

  1. Possibly modifying the molding recipe to be more difficult or take slightly longer.
  2. Leave everything as is

Testing

Loaded up the game, tested some of the recipes and verified that you can craft them with either type of bottle.

Additional context

image
image

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 11, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 11, 2022
@Maleclypse Maleclypse added <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Feb 14, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 26, 2022
@kevingranade kevingranade merged commit 429ff44 into CleverRaven:master Mar 3, 2022
@haveric haveric deleted the soap-bottle branch March 3, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate "plastic bottle" item which cannot be used to craft gallon jugs
4 participants