Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail-fast on master builds for the general matrix. #55103

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

akrieger
Copy link
Member

@akrieger akrieger commented Feb 4, 2022

Summary

None

Purpose of change

The mac osx build is more pedantic than the others and can fail at compile time when the others don't. If this happens on a master branch build though, it'll cancel the rest of the matrix jobs, which will then not upload artifacts to cache and will slowdown all future builds until a green master happens again. That sucks.

Describe the solution

Set fail-fast to false when on a master build so all build jobs attempt to make progress. This is fine because we now have better usage of github's concurrent actions functionality to prevent extraneous master branch work, so we can afford to have all the jobs eventually failing in case of a global build failure.

Describe alternatives you've considered

Nada.

Testing

Pushed to my master branch on the current broken build and the outstanding builds did not get cancelled when the osx build failed. https://github.com/akrieger/Cataclysm-DDA/actions/runs/1796382056

Additional context

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 4, 2022
@NetSysFire NetSysFire added <Bugfix> This is a fix for a bug (or closes open issue) Code: Tests Measurement, self-control, statistics, balancing. labels Feb 4, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 4, 2022
@kevingranade kevingranade merged commit e9520fc into CleverRaven:master Feb 5, 2022
@akrieger akrieger deleted the no_fastfail branch December 3, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Tests Measurement, self-control, statistics, balancing. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants