Skip installing SDL2 on ncurses build on GHA #55088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
astyled
github-actions
bot
added
the
BasicBuildPassed
scarf005
added a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Sep 25, 2023
see: CleverRaven/Cataclysm-DDA#55088 Co-authored-by: Brett Dong <[email protected]>
scarf005
added a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Sep 27, 2023
see: CleverRaven/Cataclysm-DDA#55088 Co-authored-by: Brett Dong <[email protected]>
scarf005
added a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Oct 1, 2023
see: CleverRaven/Cataclysm-DDA#55088 Co-authored-by: Brett Dong <[email protected]>
scarf005
added a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Oct 3, 2023
see: CleverRaven/Cataclysm-DDA#55088 Co-authored-by: Brett Dong <[email protected]>
github-merge-queue bot
pushed a commit
to cataclysmbnteam/Cataclysm-BN
that referenced
this pull request
Oct 13, 2023
* ci: remove EXTRA_TEST_OPTS not used ATM * ci: install SDL dependencies only for tiles build see: CleverRaven/Cataclysm-DDA#55088 Co-authored-by: Brett Dong <[email protected]> * ci: order title first for readability * ci: limit resource usages on repeated pushes see: - CleverRaven/Cataclysm-DDA#54306 - CleverRaven/Cataclysm-DDA#54617 Co-authored-by: Kevin Granade <[email protected]> * ci: add `ccache_limit` and `ccache_key` * ci: correctly cache ccache see: - CleverRaven/Cataclysm-DDA#54078 - CleverRaven/Cataclysm-DDA#64553 Co-authored-by: Kevin Granade <[email protected]> Co-authored-by: Brett Dong <[email protected]> * ci: ccache stats and cleanup see: CleverRaven/Cataclysm-DDA#64553 Co-authored-by: Brett Dong <[email protected]> * ci: write ccache from upload only see: CleverRaven/Cataclysm-DDA#54558 Co-authored-by: Andrew Krieger <[email protected]> * ci: better performance ccache options see: CleverRaven/Cataclysm-DDA@aaffb31 Co-authored-by: Andrew Krieger <[email protected]> * ci: build only and test only script see: CleverRaven/Cataclysm-DDA#54435 Co-authored-by: Brett Dong <[email protected]> Co-authored-by: Alexey <[email protected]> * ci: add some line breaks my eyes hurt * ci: skip via either code or data see: - CleverRaven/Cataclysm-DDA@5707742 - CleverRaven/Cataclysm-DDA@f6ec25f Co-authored-by: Kevin Granade <[email protected]> Co-authored-by: Andrew Krieger <[email protected]> * ci: separate build and test step see: CleverRaven/Cataclysm-DDA#54435 Co-authored-by: Brett Dong <[email protected]> * ci: bump actions/upload-artifact to v3 see: CleverRaven/Cataclysm-DDA#64962 Co-authored-by: casswedson <[email protected]> * ci: ignore upload fail after build fails see: CleverRaven/Cataclysm-DDA@b7dc997 Co-authored-by: John Bytheway <[email protected]> * ci: emit success artifact * fix: use num_jobs correctly * Update .github/workflows/matrix.yml Co-authored-by: Olanti <[email protected]> * Update .github/workflows/matrix.yml Co-authored-by: Olanti <[email protected]> * ci: remove object-creator * ci: add run-on-draft flag * ci: match languages in translation test * ci: use `upload-artifact` * Update build-scripts/gha_compile_only.sh Co-authored-by: Olanti <[email protected]> * test: fix catch2 tag format * test: mark overmap lab generation test as flaky * test: mark ranged aiming test as flaky * test: use anonymous namespace * test: adjust grenade lethality to match BN value * ci: remove gh push trigger it didn't work * ci: reduce cache limit github cache limit is 10GB * Revert "test: mark overmap lab generation test as flaky" This reverts commit 71f6840. * ci: does it work? * ci: remove `FRAMEWORK` option * ci: fix restore key --------- Co-authored-by: Brett Dong <[email protected]> Co-authored-by: Kevin Granade <[email protected]> Co-authored-by: Andrew Krieger <[email protected]> Co-authored-by: Alexey <[email protected]> Co-authored-by: casswedson <[email protected]> Co-authored-by: John Bytheway <[email protected]> Co-authored-by: Olanti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Skip installing unnecessary SDL2, X11 and audio codec libraries when doing a ncurses build. Saves 20 seconds on basic build.
Describe the solution
Describe alternatives you've considered
Testing
Additional context