Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhardcode grass cutting and add a stone sickle #55086

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

NetSysFire
Copy link
Member

Summary

Content "Unhardcode grass cutting and add a stone sickle"

Purpose of change

See #54291 (comment)

We already have a good amount of primitive stone-based tools and cutting grass is important to obtain straw.

Describe the solution

Adds GRASS_CUT, it only has one value: 1. Removed all the hardcoded tools from the grass cutting construction recipe and let it require a quality instead.

I sourced some dimensions and weight from https://artsandculture.google.com/asset/wooden-sickle-with-flint-blades/9QFQ7az8hadOsg and adapted it a bit. It is proven™ that neolithic sickles and even scythes existed and were used by neolithic folks.

Describe alternatives you've considered

Adding an item group and keeping tools in the construction recipe.

Also adding a stone scythe but there is not much use for that currently.

Testing

I did some playtesting, made sure you can cut grass as intended and craft the stone sickle. I have also slain some geese and got, as expected and intended, low damage.

Additional context

n/a

@NetSysFire NetSysFire added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Feb 4, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 4, 2022
@kevingranade
Copy link
Member

Thanks for the source, my first thought after reading the title was, "is that really a thing?" :D

@kevingranade kevingranade merged commit de49cd7 into CleverRaven:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants