-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow split coverage strings to be properly translated #54955
Conversation
I mentioned it in Discord, but when I tried the alternative approach I got an error (type mismatch?) when compiling, but since my programming skills are extremely dull, I'm not sure how would it be solved. I'm not 100% sure which approach is better anyway, but just in case here's the commit for my 2nd attempt in my local fork Faalagorn@0fe6ffc |
Changed to string_format as per @BrettDong's suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In current version there is a space before "The" and there is no space between tag and body part name.
Sorry to butt in, looks like @BrettDong and I just submitted the same suggestions. I'll retract mine. |
Co-authored-by: Binrui Dong <[email protected]>
Co-authored-by: Binrui Dong <[email protected]>
Co-authored-by: Binrui Dong <[email protected]>
Summary
None
Purpose of change
Allow some of the missing coverage strings to be translated, as they weren't if the string was full.
Describe the solution
Split the strings into two halves.
Describe alternatives you've considered
Mark just the " The " string to translate, it will require separate translations but won't result in split and , they will be hardcoded however.
Testing
Compiled the game, with the strings already translated properly (removed "The" for Polish), it appears correctly.
Additional context