Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow split coverage strings to be properly translated #54955

Merged
merged 5 commits into from
Jan 31, 2022

Conversation

Faalagorn
Copy link
Contributor

Summary

None

Purpose of change

Allow some of the missing coverage strings to be translated, as they weren't if the string was full.

Describe the solution

Split the strings into two halves.

Describe alternatives you've considered

Mark just the " The " string to translate, it will require separate translations but won't result in split and , they will be hardcoded however.

Testing

Compiled the game, with the strings already translated properly (removed "The" for Polish), it appears correctly.

Additional context

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 30, 2022
@Faalagorn
Copy link
Contributor Author

I mentioned it in Discord, but when I tried the alternative approach I got an error (type mismatch?) when compiling, but since my programming skills are extremely dull, I'm not sure how would it be solved.

I'm not 100% sure which approach is better anyway, but just in case here's the commit for my 2nd attempt in my local fork Faalagorn@0fe6ffc

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 31, 2022
src/item.cpp Outdated Show resolved Hide resolved
Changed to string_format as per @BrettDong's suggestion
Copy link
Member

@BrettDong BrettDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In current version there is a space before "The" and there is no space between tag and body part name.

src/item.cpp Outdated Show resolved Hide resolved
src/item.cpp Outdated Show resolved Hide resolved
src/item.cpp Outdated Show resolved Hide resolved
@wapcaplet
Copy link
Contributor

Sorry to butt in, looks like @BrettDong and I just submitted the same suggestions. I'll retract mine.

Faalagorn and others added 3 commits January 31, 2022 14:16
Co-authored-by: Binrui Dong <[email protected]>
Co-authored-by: Binrui Dong <[email protected]>
Co-authored-by: Binrui Dong <[email protected]>
@ZhilkinSerg ZhilkinSerg merged commit 03844f9 into CleverRaven:master Jan 31, 2022
@Faalagorn Faalagorn deleted the patch-7 branch January 31, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants