Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add looks_like to basic pipe spear #54943

Merged

Conversation

VitreousEyes110
Copy link
Contributor

Summary

None

Purpose of change

The basic pipe spear is extremely similar to the pipe spear, and is a direct crafting component in creating the pipe spear. Their decriptions and stats are nearly identical, so it makes sense for them to look the same.

Describe the solution

Add looks_like to the basic pipe spear, referring to the pipe spear.

Describe alternatives you've considered

The pipe spear does have wrappings at one end of the handle that the basic pipe spear doesn't, as well as being a centimeter shorter. This could be enough to consider them too distinct to share a texture.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 30, 2022
@BrettDong BrettDong added SDL: Tiles / Sound Tiles visual interface and sounds. [JSON] Changes (can be) made in JSON labels Jan 30, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 30, 2022
@kevingranade kevingranade merged commit ce7251f into CleverRaven:master Jan 31, 2022
@VitreousEyes110 VitreousEyes110 deleted the VitreousEyes110-pipe_spear branch January 31, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants