Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Pouch recipes, and pouch consistency check #54549

Conversation

chrispikula
Copy link
Contributor

@chrispikula chrispikula commented Jan 18, 2022

Summary

Content "Pouches: Material/Waterproofing/Mass/Recipe checkup"

Purpose of change

So, I noticed that a few new pouches were added to ammo_pouch.json recently, and could be attached to the molle vests. I thought, hey, these are cool, can I craft them? And no, I could not. So this will add the recipes for them, and while I'm here, do a consistency check on the other pouches to make sure I make the recipes in line with them, as well as spot any glaring mistakes.

Describe the solution

First pass:
Current recipes & items will have material and ingredients match, etc, leg pouch made of cotten -> nylon, due to the recipe requiring nylon. Or a quiver_large being made of steel yet it's recipe not requiring it, nor the quiver having steel material.
Proficiencies added where needed ->prof_closures_waterproofing will be added to clothing that is water_friendly. (Player description of prof_closures_waterproofing is 'waterproofing', not making watertight pockets. It's missing from half the pouches.
Recipes will be altered s.t. the number of clasps, match the number of pockets. (sometimes the small_strap was considered a clasp rather than a way it's attached to the body, or no clasps were included at all.
Consistency on secondary skills required, eg; quiver: regular quiver requires archery 1, large quiver requires gun 1 or 2.
A cordage/large strap consideration w/ large quiver. It's inconsistent.

Second pass:
Figure out if there's any anomalies when it comes to materials required vs output mass, thickness, and contains volume/weight. I'm looking here to see if there's any impossibly thin surface areas, or utterly wrong masses. Of note here is the javelin bag coming in at 600 grams, thickness 4 with 5x1.25L pockets and 30 moves to remove.
Look at pouches outside of ammo_pouch.json, such as bandolier.json, and storage.json. Return to step 1, if needed.
For pouches that already exist, PALS_SMALL, PALS_MEDIUM, PALS_LARGE flags to be considered. Flags also at this point should be added to documentation files.
Will also take a look at crafting times, w/ respect to the above and real-world considerations.

Third pass, and the original goal:
Adding the new recipes for:

radio_pouch
gadget_pouch
h2o_pouch
tool_pouch
flashlight_pouch
tactical_holster
gas_mask_pouch
tactical_grenade_pouch
triple_stacker_pouch
tactical_shotshell_pouch

Forth pass (?):
Checking loot distribution lists for the new items.

This is not planned as a single PR, but as a set of 3 or 4 PRs.

Describe alternatives you've considered

Just walking away.

Testing

Will at each stage, spawn the relevant ingredients, see if they can be crafted, that the recipes are sane.

Additional context

I considered the idea of a 'Durable Reinforcement' proficiency for clothing, especially for that which is expected to withstand combat. I don't think it's a good idea to include in this PR draft.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 18, 2022
@Maleclypse Maleclypse added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 18, 2022
@bombasticSlacks
Copy link
Contributor

Keep in mind any item with a PALS flag should actually be compatible with molle rigging. Not any pouch or item would be.

@chrispikula
Copy link
Contributor Author

Keep in mind any item with a PALS flag should actually be compatible with molle rigging. Not any pouch or item would be.

The ones that I'm thinking about would be the rock_pouch, dump_pouch, leather_pouch, legrig, armrig, flintlock_pouch, and such. A quick glance makes me think the flintlock_pouch would be PAL_LARGE, but I'll need to check the ammo size first. The grenade_pouch might also be PAL_LARGE, but I think it's too large as well.

That part is in stage two 'cause I want to figure out sizes, esp in the case of ammo. Most other pouches, currently, are too big even if they were molle (see, rock_pouch w/ 10 rocks). Also, as it'd be more ad-hock that standard molle attachments, would increasing their attachment requirements by one be a decent tradeoff? To simulate weaving the strap that'd have been belted to your waist now roping awkwardly around molle loops.

chrispikula added a commit to chrispikula/Cataclysm-DDA that referenced this pull request Feb 3, 2022
As per my plan in CleverRaven#54549 , this is a completion of the first three stages.  The added molle attachments are now craftable.

Guidelines were 3h/leather piece, 1.5h/patchwork cotton, 1.5h/lyrcra, as per the weight-time guidelines in /data/json/requirements/tailoring.json . Each molle specific item gained 1/2/3 small straps and clasps, depending on PALS_ SMALL/MEDIUM/LARGE flags, with corresponding .5h to stitch each.
Non MOLLE items that can be worn as MOLLE, like the wrist bandoleer, did not get these straps, but were generally moved one size higher in PALS_ size.

All items that were to be strapped to the body acquired a strap if they did not have one already, a large one if the volume to be stored was in excess of ~2 L.  Each strap now has a clasp to use it with.

All pouches now have 1-to-1 fasteners, especially those that before, only had clasp yet protected their contents from water, or those that used larger or fewer numbers of fasteners depending on XL/XS.

As going through this, several items were found to not have the proper amount of materials used, and were corrected.  Sorry for those of you who liked only needing 50m to make a kevlar vest, or only 6h to make 3 leather into a baldric_holster
kevingranade pushed a commit that referenced this pull request Feb 5, 2022
…\armor\storage (#55073)

* Molle Attachment Recipe addition and Consistency Check

As per my plan in #54549 , this is a completion of the first three stages.  The added molle attachments are now craftable.

Guidelines were 3h/leather piece, 1.5h/patchwork cotton, 1.5h/lyrcra, as per the weight-time guidelines in /data/json/requirements/tailoring.json . Each molle specific item gained 1/2/3 small straps and clasps, depending on PALS_ SMALL/MEDIUM/LARGE flags, with corresponding .5h to stitch each.
Non MOLLE items that can be worn as MOLLE, like the wrist bandoleer, did not get these straps, but were generally moved one size higher in PALS_ size.

All items that were to be strapped to the body acquired a strap if they did not have one already, a large one if the volume to be stored was in excess of ~2 L.  Each strap now has a clasp to use it with.

All pouches now have 1-to-1 fasteners, especially those that before, only had clasp yet protected their contents from water, or those that used larger or fewer numbers of fasteners depending on XL/XS.

As going through this, several items were found to not have the proper amount of materials used, and were corrected.  Sorry for those of you who liked only needing 50m to make a kevlar vest, or only 6h to make 3 leather into a baldric_holster

* Bugfixes, recipe simplication

Most 3 combinations of strap_large, small strap, clasp, fastener small, fastener large causes deduped_requirement_data error.*
Simplification of

legpouch_large, quiver, quiver_large, ammo_satchel, ammo_pouch, javelin_bag, stone_pouch, ammo_satchel_from leather, baldric_holster

recipies via
Fastener Small absorbs Clasp
Fastener Large absorbs Clasp

Strap shouldn't be absorbed, as it makes the recipe look "weird", and would then likely be reverted.

* Notable exception: "fastener_small", "strap_small" and "clasps".  So this means that whenever strap_large is added, such as belting or shoulder-straping something, something else has to give.

* Linting, and making the XL Kevlar vest requiring sewing
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Mar 2, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this Apr 16, 2022
@chrispikula chrispikula deleted the New_Pouch_Recipies_And_Cleanup branch August 25, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact json-styled JSON lint passed, label assigned by github actions stale Closed for lack of activity, but still valid.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants