Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorter dialog var names #53664

Merged
merged 4 commits into from
Dec 23, 2021
Merged

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Dec 21, 2021

Summary

None

Purpose of change

Variable names required 3 parts. No real reason and it was a pain in the ass to work with.
Should have done this a year ago.
Kinda sorta related to #53625

Describe the solution

Made the type and context parts of dialog var names optional, removed those parts from portal storm variables. Also removed unused Mi-Go eoc I had added previously.

Describe alternatives you've considered

Testing

Additional context

@Maleclypse
Copy link
Member

Are you planning on coming back to the mi-go ideas or were you wanting someone else to do the mi-go interest items?

@Maleclypse Maleclypse added [JSON] Changes (can be) made in JSON Mechanics: Effects / Skills / Stats Effects / Skills / Stats [C++] Changes (can be) made in C++. Previously named `Code` labels Dec 22, 2021
@Ramza13
Copy link
Contributor Author

Ramza13 commented Dec 22, 2021

Are you planning on coming back to the mi-go ideas or were you wanting someone else to do the mi-go interest items?

At the moment I don't have plans to go back to the Mi-go ideas, my overall idea there with mi-go interest needs some polish to fit with the setting and portal storms are taking all my creative juices. By all means feel free to take a swing at them, if not I may circle back after a lot more portal storm work.

@kevingranade kevingranade merged commit a137f8f into CleverRaven:master Dec 23, 2021
mkrutov pushed a commit to mkrutov/Cataclysm-DDA that referenced this pull request Dec 23, 2021
@Ramza13 Ramza13 deleted the shorter_var_names branch December 23, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Mechanics: Effects / Skills / Stats Effects / Skills / Stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants