Tailoring requirements update #53578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the material requirements for tailoring to use FABRIC_CUT This only actually affects a handful of recipes, because apparently tailoring recipes are a mess, so I'm working on them after i standardize fabric sizes.
…a-chancey/Cataclysm-DDA into tailoring-requirements-overhaul
github-actions
bot
added
json-styled
|
You have to fix the tests, too. They still expect CUT it looks like. |
NetSysFire
added
<Enhancement / Feature>
Yep I was thinking about that this morning. Gonna tackle that when I've got some spare time today |
Oops. Forgot to update the test to use the new fabric cut quality. it all passed on my end now.
Didn't have the values sorted properly so build failed remotely.
…a-chancey/Cataclysm-DDA into tailoring-requirements-overhaul
mkrutov
pushed a commit
to mkrutov/Cataclysm-DDA
that referenced
this pull request
Dec 23, 2021
* Updating the material requirements for tailoring to use fabric_cut This updates the material requirements for tailoring to use FABRIC_CUT This only actually affects a handful of recipes, because apparently tailoring recipes are a mess, so I'm working on them after i standardize fabric sizes. * sorting string declarations Didn't have the values sorted properly so build failed remotely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Tailoring requirements update"
Purpose of change
This is the next step in resolving #53436.
Describe the solution
I have updated the requirements/tailoring.json file to reflect the new FABRIC_CUT qualities, as well as add in requirement for fine cutting in a few places.
Describe alternatives you've considered
Not doing the tailoring overhaul.
Testing
loaded up the test world and checked recipes to see that FABRIC_CUT was required.
Additional context
Note that this does not fix every recipe in the game, and many them still have cut as their needed tool quality. This is due to the recipes not relying on requirements, but are specified within the recipe.
This is something i'm going to be auditing as soon as i get the sheet sizes figured out tomorrow.