Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Kevlar Shears #53366

Merged
merged 11 commits into from
Dec 17, 2021
Merged

Adding Kevlar Shears #53366

merged 11 commits into from
Dec 17, 2021

Conversation

a-chancey
Copy link
Contributor

@a-chancey a-chancey commented Dec 11, 2021

This adds kevlar shears to the game, a new Cutting Quality 2 tool, as well as putting them in appropriate spawn groups and giving them a crafting recipe.
This also updates the tailoring requirements for kevlar to include cutting 2, which is the shears.

Summary

Bugfixes "Adding Kevlar shears"

Purpose of change

This is the first PR towards #53315, adding in Kevlar Shears. This doesn't fix the reverse recipe issues that sewing 2+ requires cut 2+ to reverse, but that is beyond the scope of this PR.

Describe the solution

This gives us a cut quality 2 tool that will cover cutting Kevlar, as it requires specialized shears in real life to cut.
The Kevlar shears were given a recipe similar to scissors, but with a higher difficulty and time required, as well as a higher penalty for not having the bladesmithing proficiency, since they're a different type of blade and serrated.
The PR also increases tailoring requirements for Kevlar working.

Describe alternatives you've considered

reducing the recipes to use Cut 1, adding alternative Cut 2 items (soon), adjusting the reverse recipe function to pull from a defined list of valid qualities.

Testing

Spawned in shears and Kevlar gear, was able to disassemble it just fine. Teleported to a few loot spawn locations (mansions, sewing craft store) and found the shears there.

Additional context

There's still an issue with reversing recipes that a quality can appear twice, I'll file an issue on this later.

This adds kevlar shears to the game, as well as putting them in appropriate spawn groups and giving them a crafting recipe.
This also updates the tailoring requirements for kevlar to include cutting 2, which is the shears.
@wapcaplet wapcaplet added Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON labels Dec 11, 2021
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 12, 2021
Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looking good, but I think the frequencies are rather high here. Even my suggested frequencies may be too much.

data/json/itemgroups/Locations_MapExtras/mansion.json Outdated Show resolved Hide resolved
data/json/itemgroups/SUS/clothes_store.json Outdated Show resolved Hide resolved
data/json/itemgroups/SUS/domestic.json Outdated Show resolved Hide resolved
data/json/itemgroups/tools.json Outdated Show resolved Hide resolved
data/json/items/tool/tailoring.json Outdated Show resolved Hide resolved
@a-chancey
Copy link
Contributor Author

Mostly looking good, but I think the frequencies are rather high here. Even my suggested frequencies may be too much.

I'll tone them down and check them at your suggested rates. If they still seem to frequent I can bump them down - after all, they are craftable.

In the issue I mentioned also reworking sewing and tailors kits slightly as well, if you have any feedback it would be appreciated.

A sewing kit is going to need some sort of cutting tool in order to trim fabric and cut thread. I was considering adding scissors or one of a handful of knives as an ingredient and giving the sewing kit CUT 1 as well. A quick search shows that pretty much any commercially available sewing kit will come with at least small scissors.

A tailor's kit includes more specialized tools - so I was considering adding the Kevlar shears to it and giving it CUT 2.

Based on my reading, Nomex should actually require a similar type of shear to cut smoothly as well, and it was suggested to me that it and synthetic fabric also be given the CUT 2 requirement. This would help reduce that extra inventory item later on, and I think has realistic reasoning behind the change.

a-chancey and others added 6 commits December 13, 2021 09:27
Updating with I-am-Erk's suggestions

Co-authored-by: I-am-Erk <[email protected]>
Updating with I-am-Erk's suggestions

Co-authored-by: I-am-Erk <[email protected]>
Updating with I-am-Erk's suggestions

Co-authored-by: I-am-Erk <[email protected]>
Updating with I-am-Erk's suggestions

Co-authored-by: I-am-Erk <[email protected]>
Updating with I-am-Erk's suggestions

Co-authored-by: I-am-Erk <[email protected]>
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 16, 2021
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 17, 2021
@I-am-Erk I-am-Erk merged commit e467981 into CleverRaven:master Dec 17, 2021
@a-chancey a-chancey deleted the Kevlar-Shears branch January 11, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants