-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Kevlar Shears #53366
Adding Kevlar Shears #53366
Conversation
This adds kevlar shears to the game, as well as putting them in appropriate spawn groups and giving them a crafting recipe. This also updates the tailoring requirements for kevlar to include cutting 2, which is the shears.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looking good, but I think the frequencies are rather high here. Even my suggested frequencies may be too much.
I'll tone them down and check them at your suggested rates. If they still seem to frequent I can bump them down - after all, they are craftable. In the issue I mentioned also reworking sewing and tailors kits slightly as well, if you have any feedback it would be appreciated. A sewing kit is going to need some sort of cutting tool in order to trim fabric and cut thread. I was considering adding scissors or one of a handful of knives as an ingredient and giving the sewing kit CUT 1 as well. A quick search shows that pretty much any commercially available sewing kit will come with at least small scissors. A tailor's kit includes more specialized tools - so I was considering adding the Kevlar shears to it and giving it CUT 2. Based on my reading, Nomex should actually require a similar type of shear to cut smoothly as well, and it was suggested to me that it and synthetic fabric also be given the CUT 2 requirement. This would help reduce that extra inventory item later on, and I think has realistic reasoning behind the change. |
Updating with I-am-Erk's suggestions Co-authored-by: I-am-Erk <[email protected]>
Updating with I-am-Erk's suggestions Co-authored-by: I-am-Erk <[email protected]>
Updating with I-am-Erk's suggestions Co-authored-by: I-am-Erk <[email protected]>
Updating with I-am-Erk's suggestions Co-authored-by: I-am-Erk <[email protected]>
Updating with I-am-Erk's suggestions Co-authored-by: I-am-Erk <[email protected]>
Now that fabric_cut exists, i added it to the kevlar shears
This adds kevlar shears to the game, a new Cutting Quality 2 tool, as well as putting them in appropriate spawn groups and giving them a crafting recipe.
This also updates the tailoring requirements for kevlar to include cutting 2, which is the shears.
Summary
Bugfixes "Adding Kevlar shears"
Purpose of change
This is the first PR towards #53315, adding in Kevlar Shears. This doesn't fix the reverse recipe issues that sewing 2+ requires cut 2+ to reverse, but that is beyond the scope of this PR.
Describe the solution
This gives us a cut quality 2 tool that will cover cutting Kevlar, as it requires specialized shears in real life to cut.
The Kevlar shears were given a recipe similar to scissors, but with a higher difficulty and time required, as well as a higher penalty for not having the bladesmithing proficiency, since they're a different type of blade and serrated.
The PR also increases tailoring requirements for Kevlar working.
Describe alternatives you've considered
reducing the recipes to use Cut 1, adding alternative Cut 2 items (soon), adjusting the reverse recipe function to pull from a defined list of valid qualities.
Testing
Spawned in shears and Kevlar gear, was able to disassemble it just fine. Teleported to a few loot spawn locations (mansions, sewing craft store) and found the shears there.
Additional context
There's still an issue with reversing recipes that a quality can appear twice, I'll file an issue on this later.