Display martial arts weapons by category

[dseguin]

Summary

None

Purpose of change

Just a simple QoL feature. Fixes #52614.

Describe the solution

This separates the martial arts weapons list into categories. As a side improvement, this also highlights items in the player's inventory in yellow.

Describe alternatives you've considered

Creating a separate screen for listing weapons by category, accessible via keypress on the martial arts info screen.

Testing

Additional context

Something to keep in mind is that weapon categories exist only as JSON elements, which makes it impossible (I think) to translate via gettext in the code itself.

[Saicchi]

Something to keep in mind is that weapon categories exist only as JSON elements, which makes it impossible (I think) to translate via gettext in the code itself.

I'll work on that.

[Termineitor244]

Thank you @dseguin!

[Termineitor244]

Looking at your screenshots... You are displaying the categories based on the weapons used by the style, the current implementation means that, if a weapon is used in more than one category (like some of the polearms right now) then all of its categories would appear in the styles that use it, even if the other categories are not in use by the martial art in question.

Sojutsu use of weapon categories is still pending to be merged to master, and it only uses POLEARMS, but HOOKING POLEARMS appears in your screenshot, this could lead to some confusion for the player about what category is actually being used by the martial art.

Wouldn't it be better to display the weapons based by the categories defined in the martial art JSON? Sojutsu would only have a single category being showed but it would be more clear what kind of weapon should be used by the martial art.

[dseguin]

So I've tried a few ways to address this and I think I found an acceptable solution:

For martial arts that don't specify weapon categories (ex: Fencing), list all categories from the list of valid weapons:

For martial arts that use weapon categories (ex: Sojutsu), only list the defined categories:

Valid weapons that are uncategorized or not in the martial art's weapon categories are classified as "OTHER".

[Termineitor244]

@dseguin thank you! This works like a charm!

[AcidAntOnAMinefield]

Will there be an "unarmed" category, as well as having unarmed weapons displayed in the F1 Menu for the unarmed martial arts styles?

[dseguin]

Will there be an "unarmed" category, as well as having unarmed weapons displayed in the F1 Menu for the unarmed martial arts styles?

I think that's up to the people working on martial arts. This PR doesn't add or remove categories, it just changes how the existing MA weapons are displayed in the info screen.

[Termineitor244]

Will there be an "unarmed" category, as well as having unarmed weapons displayed in the F1 Menu for the unarmed martial arts styles?

I personally don't have any plans to add one, since they use a different system than the style weapons (They are defined by a json flag, and are already "categorized" in that sense), but I'm not against adding it per se.

This PR is about displaying martial arts categories, for discussion about the categories in question you should direct your comments at #51867.