Refactor martial arts buff requirements check #52501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettDong
added
[C++]
|
This pull request fixes 2 alerts when merging 2dcf312 into 25d9d00 - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
LGTM.com reports two empty
if()blocks inma_requirements::is_valid_character(), which is probably an oversight in #51950:https://lgtm.com/projects/g/CleverRaven/Cataclysm-DDA/snapshot/e76e68e3d1b64e04cc0ec5f9f65f001330d3a646/files/src/martialarts.cpp#x6cef958d535d15b2:1
While trying to fix the warning, I feel that this part of the code can be simplified and made more intuitive with
std::any_of()andstd::all_of().Describe the solution
Refactor martial arts buff requirements check.
Describe alternatives you've considered
Testing
Additional context