[CR] Weapon Categories: Silat (And Polearms categories)

[Termineitor244]

Summary

Balance "Add weapon categories for Silat"

Purpose of change

Partially implements #51867.
Silat: These martial art weapons are a mess, it has knives, batons, quarterstaves, farming tools, spears, polearms that are not spears, and even a few swords thrown in the bunch! And I thought Ninjutsu was overpowered...
This martial art needs a serious revision in available weapons, it does not make sense to use such wide and different range of weapons, even as a "catch all" style that is supposed to represent a bunch of different styles, it needs consistency.

Describe the solution

Weapon Category	Martial Art	Includes
KNIVES	Silat, Eskrima, Ninjutsu, Krav Maga	All kind of knives
BATONS	Silat, Eskrima, Krav Maga	Batons, tonfas and weapons of similar shape
QUARTERSTAVES	Silat, Ninjutsu	Quarterstaves and similar weapons
BLADED_FARMING	Silat, Eskrima, Ninjutsu	Bladed farming tools and the machetes
HOOKING_POLEARMS	Silat	Polearms with something to make a "Hook"
POLEARMS	Silat	Polearms in general, including spears and the like

KNIVES, BATONS, QUARTERSTAVES and BLADED_FARMING are already used by Krav Maga, Ninjutsu and/or Eskrima the additional weapons to these categories are the pool cue (quarterstaff) and the scythes (bladed farming).

2 new weapons category:

• HOOKING_POLEARMS
  This weapon category is created to be of use to Fior Di Battaglia, since, as the creator @DemAvalon said in Medieval Polearm martial arts. #31601, the martial art has a focus in "displacing one's opponents strikes creating openings for them to be "hooked"", it was added here since Silat uses these weapons too, and to differentiate them from the classical spears, the weapons in this style should have a head in the end to hook the opponent, like the glaive, halberd and other polearms.

• POLEARMS
  This category is for polearms in general, created with the Sōjutsu in mind.

I removed some weapons that make no sense to be in the style, and removed the swords too, since the style is too bloated already and it only has 2 variants of swords (One added in a PR months ago with no justification).

Describe alternatives you've considered

Many alternatives, I want to remove the polearms from the style or change the style to work only with polearms/long weapons, or create a different silat for polearms, but since the weapons of this kind are many and are already in the style, I decided to wait from the opinions of other developers.

Testing

None.

Additional context

There needs to be a way to display the categories in the martial art info menu.

@Hymore246, what is your opinion in the weapon situation of Silat, and, since you are the creator of Sōjutsu, what is your current stance on its weapon categories? In your original PR #27535 you said you added the style as way to "add more variety and support for reach weapon users", does that means that it should include both spears and weapons like the glaive and halberd? (Like it already does).

[Hymore246]

Sojutsu is focuses on using spears to fight but I see no reason that other reach weapons of a similar size with a point wouldn't also work with the style. So weapons like glaives and halberds are ok in my book since you can use them the same way you would a spear. A style that restricts its weapons too much will become difficult to use. This was the original problem with Niten-Ichi Ryu before I added more style weapons.

[Termineitor244]

Sojutsu is focuses on using spears to fight but I see no reason that other reach weapons of a similar size with a point wouldn't also work with the style. So weapons like glaives and halberds are ok in my book since you can use them the same way you would a spear. A style that restricts its weapons too much will become difficult to use. This was the original problem with Niten-Ichi Ryu before I added more style weapons.

Hmmmm ok, then I will change "PIERCING_POLEARMS" to... I don't know, just "POLEARMS" and add the category to the rest of the weapons too (Since no other martial art in the game, to my knowledge, uses polearms/spears).

[Termineitor244]

I rebased the branch to the current master, if there are no further conflicts, this should be ready to merge.