-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wattle fences #49156
Add wattle fences #49156
Conversation
Under "purpose of change", if you replace "Regarding" by "To fix" it should link your PR to the regarding issue/feature request. ( it then closes the issue if this PR is merged ) |
52975c2
to
3fd2d65
Compare
3fd2d65
to
e570d57
Compare
Is it currently not possible to add proficiency to construction? As noted by @NetSysFire in #49138 I think we decided it was probably best for wattle such as this to use the weaving proficiency. |
Co-authored-by: Binrui Dong <[email protected]>
To the best of my knowledge, no, you cannot use proficiencies in construction. One workaround I can think of is to make a 'wattle_panel' item (which would require the proficiency) which is then used in the construction. However, I decided not to do that for two reasons - one, it adds an item for the sole purpose of a construction, and two, it makes the construction less consistant with the other constructions (i.e. you can construct a concrete floor with no knowledge of how to smooth such a floor, so it falls to reason that you can construct a woven wall without knowing how to weave a basket). |
You'll need to update the blueprint requirements; see https://travis-ci.org/github/CleverRaven/Cataclysm-DDA/jobs/773665090. |
Oh wow ok I see, I didn't expect to break that (never seen that before) when adding an alternate recipe for the wattle-and-daub wall. |
Summary
Content "Adds a wattle fence"
Purpose of change
To fix #49138.
Allows the player to create a weak, impassible fence completely out of wood.
Describe the solution
Added construction recipe for wattle fence posts (requiring sticks/pointy sticks and diggable ground).
Added construction recipe for wattle fence (requires more sticks and wattle fence posts).
Added the appropriate terrain tiles for the above.
Also added a construction recipe to reinforce this wattle fence into a wattle and daub wall (requires the other ingredients from the wattle-and-daub wall, plus some extra sticks/2x4s).
Describe alternatives you've considered
Possibly make it require more sticks, or add a new type of stick for this application - the current branches are too thick.
Also, potentially change the deconstruction result away from splintered wood - the reason I chose that is I'm assuming the player is splitting the sticks in half lengthwise so it's flexible enough to bend, but resulting in something which is no longer the original stout branch.
Testing
Loaded modified JSON, construction recipes showed up and performed as expected.
Additional context
None.