Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wattle fences #49156

Merged
merged 6 commits into from
Jun 14, 2021
Merged

Conversation

Delta5861
Copy link
Contributor

@Delta5861 Delta5861 commented Jun 3, 2021

Summary

Content "Adds a wattle fence"

Purpose of change

To fix #49138.
Allows the player to create a weak, impassible fence completely out of wood.

Describe the solution

Added construction recipe for wattle fence posts (requiring sticks/pointy sticks and diggable ground).
Added construction recipe for wattle fence (requires more sticks and wattle fence posts).
Added the appropriate terrain tiles for the above.

Also added a construction recipe to reinforce this wattle fence into a wattle and daub wall (requires the other ingredients from the wattle-and-daub wall, plus some extra sticks/2x4s).

Describe alternatives you've considered

Possibly make it require more sticks, or add a new type of stick for this application - the current branches are too thick.
Also, potentially change the deconstruction result away from splintered wood - the reason I chose that is I'm assuming the player is splitting the sticks in half lengthwise so it's flexible enough to bend, but resulting in something which is no longer the original stout branch.

Testing

Loaded modified JSON, construction recipes showed up and performed as expected.

Additional context

None.

@Zeropol
Copy link
Contributor

Zeropol commented Jun 3, 2021

Under "purpose of change", if you replace "Regarding" by "To fix" it should link your PR to the regarding issue/feature request. ( it then closes the issue if this PR is merged )

@BrettDong BrettDong added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON labels Jun 4, 2021
@faefux
Copy link
Contributor

faefux commented Jun 4, 2021

Is it currently not possible to add proficiency to construction? As noted by @NetSysFire in #49138 I think we decided it was probably best for wattle such as this to use the weaving proficiency.

Co-authored-by: Binrui Dong <[email protected]>
@Delta5861
Copy link
Contributor Author

Is it currently not possible to add proficiency to construction? As noted by @NetSysFire in #49138 I think we decided it was probably best for wattle such as this to use the weaving proficiency.

To the best of my knowledge, no, you cannot use proficiencies in construction. One workaround I can think of is to make a 'wattle_panel' item (which would require the proficiency) which is then used in the construction. However, I decided not to do that for two reasons - one, it adds an item for the sole purpose of a construction, and two, it makes the construction less consistant with the other constructions (i.e. you can construct a concrete floor with no knowledge of how to smooth such a floor, so it falls to reason that you can construct a woven wall without knowing how to weave a basket).
Overall however, I agree about proficiencies in construction. It would be a good addition.

@BrettDong
Copy link
Member

You'll need to update the blueprint requirements; see https://travis-ci.org/github/CleverRaven/Cataclysm-DDA/jobs/773665090.

@Delta5861
Copy link
Contributor Author

Delta5861 commented Jun 6, 2021

You'll need to update the blueprint requirements; see https://travis-ci.org/github/CleverRaven/Cataclysm-DDA/jobs/773665090.

Oh wow ok I see, I didn't expect to break that (never seen that before) when adding an alternate recipe for the wattle-and-daub wall.
Edit: Would this issue be fixed by changing the orderings of the recipies? I.e., instead of putting my new wattle-and-daub wall construction before the existing one (and thus the first result in the construction menu), I could put it after the existing recipes so it isn't chosen? I'm not sure how the blueprints work.

@ZhilkinSerg ZhilkinSerg merged commit 662ed4b into CleverRaven:0.F-dev Jun 14, 2021
@ZhilkinSerg ZhilkinSerg mentioned this pull request Jun 14, 2021
14 tasks
ZhilkinSerg pushed a commit that referenced this pull request Jun 14, 2021
ZhilkinSerg pushed a commit that referenced this pull request Jun 14, 2021
ZhilkinSerg pushed a commit that referenced this pull request Jun 14, 2021
@Delta5861 Delta5861 deleted the add_wattle_fences branch June 16, 2021 06:38
ZhilkinSerg pushed a commit that referenced this pull request Jun 21, 2021
ZhilkinSerg pushed a commit that referenced this pull request Jul 3, 2021
anothersimulacrum pushed a commit to anothersimulacrum/Cataclysm-DDA that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Wattle fences
5 participants