-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added recipe activity level to crafting screen. #49026
Added recipe activity level to crafting screen. #49026
Conversation
Maybe adding a color corresponding to the level of the activity? the higher it is the more red the text gets? |
@Fris0uman: Too fiddly imho (not enough shades of red in curses) and also VERY unfriendly to color-blind folks. |
Ok but maybe a grey/yellow/red thing then, something that tells you "pay attention this is exhausting work" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing the errors.
Co-authored-by: Saicchi <[email protected]>
This namespace is presently only used as a wrapper to make `activity_level_str` accessible to the crafting GUI, per CleverRaven#49026. I intend to move several other descriptive functions defined in `panels.h|cpp` into this namespace, making it a more general-purpose collection of descriptive text and color translation methods. Hence, the namespace is here renamed to `display`.
This namespace is presently only used as a wrapper to make `activity_level_str` accessible to the crafting GUI, per CleverRaven#49026. I intend to move several other descriptive functions defined in `panels.h|cpp` into this namespace, making it a more general-purpose collection of descriptive text and color translation methods. Hence, the namespace is here renamed to `display`.
This namespace is presently only used as a wrapper to make `activity_level_str` accessible to the crafting GUI, per CleverRaven#49026. I intend to move several other descriptive functions defined in `panels.h|cpp` into this namespace, making it a more general-purpose collection of descriptive text and color translation methods. Hence, the namespace is here renamed to `display`.
This namespace is presently only used as a wrapper to make `activity_level_str` accessible to the crafting GUI, per CleverRaven#49026. I intend to move several other descriptive functions defined in `panels.h|cpp` into this namespace, making it a more general-purpose collection of descriptive text and color translation methods. Hence, the namespace is here renamed to `display`.
Summary
Interface "Added recipe activity level to crafting screen"
Purpose of change
I'd like to know if boiling water for three hours will make me tired.
Describe the solution
Added "Activity level" line to the crafting screen.
Describe alternatives you've considered
I'm not very happy with leaving
activity_level_str
inpanels.cpp
if it's used outside, but I didn't find any good place to put it.Testing
Loaded a game and looked at the crafting screen.
Additional context
(I guess it won't)