Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recipe activity level to crafting screen. #49026

Merged
merged 2 commits into from
Jul 10, 2021

Conversation

Kelenius
Copy link
Contributor

Summary

Interface "Added recipe activity level to crafting screen"

Purpose of change

I'd like to know if boiling water for three hours will make me tired.

Describe the solution

Added "Activity level" line to the crafting screen.

Describe alternatives you've considered

I'm not very happy with leaving activity_level_str in panels.cpp if it's used outside, but I didn't find any good place to put it.

Testing

Loaded a game and looked at the crafting screen.

Additional context

image
image
(I guess it won't)

@Fris0uman
Copy link
Contributor

Maybe adding a color corresponding to the level of the activity? the higher it is the more red the text gets?

@Zireael07
Copy link
Contributor

@Fris0uman: Too fiddly imho (not enough shades of red in curses) and also VERY unfriendly to color-blind folks.

@actual-nh actual-nh added 0.F Feature Freeze <Enhancement / Feature> New features, or enhancements on existing Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc. labels May 25, 2021
@Fris0uman
Copy link
Contributor

Ok but maybe a grey/yellow/red thing then, something that tells you "pay attention this is exhausting work"

Copy link
Contributor

@Saicchi Saicchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the errors.

src/panels.cpp Outdated Show resolved Hide resolved
src/panels.h Outdated Show resolved Hide resolved
@kevingranade kevingranade merged commit 25cf01e into CleverRaven:master Jul 10, 2021
wapcaplet added a commit to wapcaplet/Cataclysm-DDA that referenced this pull request Aug 22, 2021
This namespace is presently only used as a wrapper to make
`activity_level_str` accessible to the crafting GUI, per CleverRaven#49026.

I intend to move several other descriptive functions defined in
`panels.h|cpp` into this namespace, making it a more general-purpose
collection of descriptive text and color translation methods. Hence, the
namespace is here renamed to `display`.
wapcaplet added a commit to wapcaplet/Cataclysm-DDA that referenced this pull request Aug 24, 2021
This namespace is presently only used as a wrapper to make
`activity_level_str` accessible to the crafting GUI, per CleverRaven#49026.

I intend to move several other descriptive functions defined in
`panels.h|cpp` into this namespace, making it a more general-purpose
collection of descriptive text and color translation methods. Hence, the
namespace is here renamed to `display`.
wapcaplet added a commit to wapcaplet/Cataclysm-DDA that referenced this pull request Aug 26, 2021
This namespace is presently only used as a wrapper to make
`activity_level_str` accessible to the crafting GUI, per CleverRaven#49026.

I intend to move several other descriptive functions defined in
`panels.h|cpp` into this namespace, making it a more general-purpose
collection of descriptive text and color translation methods. Hence, the
namespace is here renamed to `display`.
Venera3 pushed a commit to Venera3/Cataclysm-DDA that referenced this pull request Sep 21, 2021
This namespace is presently only used as a wrapper to make
`activity_level_str` accessible to the crafting GUI, per CleverRaven#49026.

I intend to move several other descriptive functions defined in
`panels.h|cpp` into this namespace, making it a more general-purpose
collection of descriptive text and color translation methods. Hence, the
namespace is here renamed to `display`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants