Fix recent clang-tidy check launch failure #49000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettDong
added
Code: Tests
ZhilkinSerg
added a commit
that referenced
this pull request
May 31, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Jun 14, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Jun 14, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Jun 14, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Jun 21, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Jul 3, 2021
anothersimulacrum
pushed a commit
to anothersimulacrum/Cataclysm-DDA
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
clang-tidycheck fails to launch recently with the error saying cannot findclickpython module.Describe the solution
Installing
clickversion 7.1.2 solves the problem.clickreleased a new version8.0.0on May 11 and that's probably the cause of the error.Testing
clang-tidycheck now launches successfully: https://github.com/BrettDong/Cataclysm-DDA/runs/2647681073Additional context
Again, this may need to be reverted after #48739 is merged.