Remove "burst" from the code for good #48856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fris0uman
changed the title
Maleclypse
added
Game: Mechanics Change
|
What effects will this have on third-party mods? Should it be under Feature Freeze due to that? |
|
Don't know if it should be feature freeze, it's not urgent so there's no problem to wait to after 0.F to merge it. Mods that still use "burst" will display an error on load and the guns using it will lose their burst fire mode. |
|
Agreed we should delay this until post-release, as it's currently documented as working this way. |
ZhilkinSerg
pushed a commit
that referenced
this pull request
May 28, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
May 31, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Jun 14, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Jun 14, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Jun 14, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Jun 21, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Jul 3, 2021
anothersimulacrum
pushed a commit
to anothersimulacrum/Cataclysm-DDA
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Remove "burst" from the coe for good"
Purpose of change
Part of #36110
Describe the solution
Remove all reference to "burst": from the json
Replace the last one with the appropirate "modes" entry
Update JSON_INFO.md accordingly
Remove now unused c++ code
Describe alternatives you've considered
Testing
Load game without error
Additional context
I'm not 100% sure of what I wrote about
"modes":in the doc, but I think that's how it works