Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations not working on Windows for some Windows languages #48176

Merged
merged 2 commits into from
Mar 21, 2021

Conversation

BrettDong
Copy link
Member

Summary

Bugfixes "Fix translations not working on Windows for some Windows languages"

Purpose of change

Fix #45238 : Translations fail to work on Windows for certain combinations of system language and region settings, for example "Russian (Ukraine)", "Russian (Kazakhstan)", "Chinese (Hong Kong SAR)".

Describe the solution

Setting LANG environment variable solves the problem.

Testing

Tested on Windows 10 20H2:

Before before
After after

@BrettDong BrettDong added Translation I18n OS: Windows Issues related to Windows operating system [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Mar 21, 2021
@ZhilkinSerg ZhilkinSerg merged commit 9c8c3f3 into CleverRaven:master Mar 21, 2021
@BrettDong BrettDong deleted the windows branch March 31, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` OS: Windows Issues related to Windows operating system Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When changing the game language, only some lines change
2 participants