Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description for Uyen's missions #48026

Merged
merged 1 commit into from
Mar 14, 2021

Conversation

akirashirosawa
Copy link
Contributor

@akirashirosawa akirashirosawa commented Mar 14, 2021

Summary

None

Purpose of change

Fix #48025

Describe the solution

Removed the rewards from the mission name and added them to the description.

Describe alternatives you've considered

Process the function format_tokenized_description also the name. But, in fact, there is no need to write the reward in the name of the mission. (PR #48027)

Testing

2

Additional context

I also checked other missions. In other missions, reward_count is in the description, as it should.

@anothersimulacrum
Copy link
Member

If you do the alternative, that does it without changing any strings. As is, I am fairly sure you are adding new strings that require translation.

@anothersimulacrum anothersimulacrum added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON 0.F String Freeze labels Mar 14, 2021
@ZhilkinSerg ZhilkinSerg changed the base branch from master to 0.F-dev March 14, 2021 20:36
@ZhilkinSerg ZhilkinSerg merged commit 9bc46f7 into CleverRaven:0.F-dev Mar 14, 2021
@ZhilkinSerg ZhilkinSerg mentioned this pull request Mar 14, 2021
14 tasks
ZhilkinSerg pushed a commit that referenced this pull request Mar 31, 2021
ZhilkinSerg pushed a commit that referenced this pull request Mar 31, 2021
BrettDong pushed a commit that referenced this pull request Apr 5, 2021
ZhilkinSerg pushed a commit that referenced this pull request Apr 7, 2021
ZhilkinSerg pushed a commit that referenced this pull request Apr 9, 2021
ZhilkinSerg pushed a commit that referenced this pull request Apr 20, 2021
ZhilkinSerg pushed a commit that referenced this pull request Apr 20, 2021
ZhilkinSerg pushed a commit that referenced this pull request Apr 20, 2021
ZhilkinSerg pushed a commit that referenced this pull request May 28, 2021
ZhilkinSerg pushed a commit that referenced this pull request May 28, 2021
ZhilkinSerg pushed a commit that referenced this pull request May 31, 2021
ZhilkinSerg pushed a commit that referenced this pull request Jun 14, 2021
ZhilkinSerg pushed a commit that referenced this pull request Jun 14, 2021
ZhilkinSerg pushed a commit that referenced this pull request Jun 14, 2021
ZhilkinSerg pushed a commit that referenced this pull request Jun 21, 2021
ZhilkinSerg pushed a commit that referenced this pull request Jul 3, 2021
anothersimulacrum pushed a commit to anothersimulacrum/Cataclysm-DDA that referenced this pull request Jul 3, 2021
KorGgenT pushed a commit to KorGgenT/Cataclysm-DDA that referenced this pull request Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<reward_count:FMCNote> in mission description
3 participants