-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add description for Uyen's missions #48026
Merged
ZhilkinSerg
merged 1 commit into
CleverRaven:0.F-dev
from
akirashirosawa:fix-reward_count
Mar 14, 2021
Merged
add description for Uyen's missions #48026
ZhilkinSerg
merged 1 commit into
CleverRaven:0.F-dev
from
akirashirosawa:fix-reward_count
Mar 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you do the alternative, that does it without changing any strings. As is, I am fairly sure you are adding new strings that require translation. |
anothersimulacrum
added
<Bugfix>
This is a fix for a bug (or closes open issue)
[JSON]
Changes (can be) made in JSON
0.F String Freeze
labels
Mar 14, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 31, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 31, 2021
BrettDong
pushed a commit
that referenced
this pull request
Apr 5, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 7, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 9, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 20, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 20, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 20, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
May 28, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
May 28, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
May 31, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Jun 14, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Jun 14, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Jun 14, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Jun 21, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Jul 3, 2021
anothersimulacrum
pushed a commit
to anothersimulacrum/Cataclysm-DDA
that referenced
this pull request
Jul 3, 2021
KorGgenT
pushed a commit
to KorGgenT/Cataclysm-DDA
that referenced
this pull request
Jul 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix #48025
Describe the solution
Removed the rewards from the mission name and added them to the description.
Describe alternatives you've considered
Process the function
format_tokenized_description
also the name. But, in fact, there is no need to write the reward in the name of the mission. (PR #48027)Testing
Additional context
I also checked other missions. In other missions,
reward_count
is in the description, as it should.