Remove unused FATIGUE energy source from spells #47852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
[C++]
chaosvolt
added a commit
to chaosvolt/cdda-arcana-mod
that referenced
this pull request
Mar 4, 2021
Updated Magic Signs in the DDA version to use mana instead of fatigue. Caused by CleverRaven/Cataclysm-DDA#47852 existing basically solely to fuck over modders, because evidently if a feature is underused in-repo the answer is to axe it instead of find a use for it. Of course Arcana being the only thing that used it probably added some encouragment to remove it.
|
Its not broken, why remove it? Do you hate modders that much? Hurts potentiall for future maglysm spells too |
|
@adamkad1: Can be easily reverted if/when someone does make a spell requiring it. |
|
But will they want to revert it? i feel like this is here to perpetuate the vendetta against chaosvolt that everyone has. But if they would be willing to revert it, i'd be more than eager to come up with something |
It was not used in mods. |
Besdies the one that doesnt exist |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fatigue is not used by any spell, this streamlines the spell casting code by removing dead code.
Describe the solution
Remove Fatigue enum and the code using it
Edit documentation accordingly
Remove debug fatigue spell
Describe alternatives you've considered
Testing
Additional context