Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn all the remaining bare name strings into name objects #46964

Merged
merged 39 commits into from
Jan 27, 2021
Merged

turn all the remaining bare name strings into name objects #46964

merged 39 commits into from
Jan 27, 2021

Conversation

TheGoatGod
Copy link
Contributor

@TheGoatGod TheGoatGod commented Jan 23, 2021

Summary

SUMMARY: Infrastructure "turn all the remaining bare name strings into name objects"

Purpose of change

I felt that I could help with the bare name and add into name objects

Describe the solution

use my name.py to update remaining bare names into name objects

Describe alternatives you've considered

doing this by hand and not with a script

Testing

tested and works as intended

@TheGoatGod TheGoatGod changed the title name str updates turn all the remaining bare name strings into name objects Jan 23, 2021
@BrettDong BrettDong added [JSON] Changes (can be) made in JSON [Python] Code made in Python Code: Tooling Tooling that is not part of the main game but is part of the repo. labels Jan 23, 2021
@actual-nh

This comment has been minimized.

tools/name.py Outdated Show resolved Hide resolved
tools/name.py Outdated Show resolved Hide resolved
tools/name.py Outdated Show resolved Hide resolved
tools/name.py Outdated Show resolved Hide resolved
tools/name.py Outdated Show resolved Hide resolved
tools/name.py Outdated Show resolved Hide resolved
tools/name.py Outdated Show resolved Hide resolved
tools/name.py Outdated Show resolved Hide resolved
TheGoatGod and others added 6 commits January 25, 2021 04:37
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: Serhiy Zahoriya <[email protected]>
Co-authored-by: Serhiy Zahoriya <[email protected]>
Co-authored-by: Serhiy Zahoriya <[email protected]>
Co-authored-by: Serhiy Zahoriya <[email protected]>
@int-ua
Copy link
Contributor

int-ua commented Jan 25, 2021

What is the benefit of converting bare strings into objects? Is there anything that outweighs adding complexity?

@int-ua
Copy link
Contributor

int-ua commented Jan 25, 2021

Since this script is working with JSON, please put it into tools/json_tools directory. And use a filename that is more descriptive.

@int-ua
Copy link
Contributor

int-ua commented Jan 25, 2021

Two last comments also apply to #47014 and #47015

@TheGoatGod
Copy link
Contributor Author

Since this script is working with JSON, please put it into tools/json_tools directory. And use a filename that is more descriptive.

do you have any suggestions?

@int-ua
Copy link
Contributor

int-ua commented Jan 25, 2021

a filename that is more descriptive.

do you have any suggestions?

name_strings_to_objects.py ?

@ZhilkinSerg ZhilkinSerg merged commit c83a5a1 into CleverRaven:master Jan 27, 2021
@UmbralReaper
Copy link
Contributor

What is the benefit of converting bare strings into objects? Is there anything that outweighs adding complexity?

#36110

@TheGoatGod TheGoatGod deleted the name-str/str_pl/str_pl-updates branch February 11, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Tooling Tooling that is not part of the main game but is part of the repo. [JSON] Changes (can be) made in JSON [Python] Code made in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants