Initial commit to add hallula bread type

[ToxiClay]

Summary

SUMMARY: Features "Adding hallula, a bread type common in Chile and Bolivia"

Purpose of change

A brief discussion on Discord posited the addition of a new bread type that would serve as an alternate use for the literal gallons of cooking oil survivors probably have.

Thanks to Svankensen for the suggestion!

Describe the solution

I updated the two JSON files the game appears to pull from: ./data/json/items/comestibles/bread.json to set the item in the world, and ./data/json/items/recipes/bread.json to add it to the list the player can cook.

The information was largely copied from the data for brown_bread, as I didn't know what data would fit better.

Describe alternatives you've considered

Testing

JSON linting performed. Because this was a JSON change, it did not require a game rebuild to integration-test it. Further work may be required to populate this item in the world, unless my data-copying caused it to inherit from its parent item.

Additional context

The recipe I drew from, for the record.

[anothersimulacrum]

Fixes #46279

[Svankensen]

Thanks! Worth mentioning that milk is optional? It is only used for "glazing"and making the bread look brown. Given that in the cataclysm milk can only be gotten from livestock, it may be a good idea to do without it.

EDIT: I see your recipe uses half milk instead of water. Most common ones don't.

https://www.enmicocinahoy.cl/un-clasico-pan-chileno-hallullas-a-chilean-bread/

[ToxiClay]

Thanks! Worth mentioning that milk is optional? It is only used for "glazing"and making the bread look brown. Given that in the cataclysm milk can only be gotten from livestock, it may be a good idea to do without it.

EDIT: I see your recipe uses half milk instead of water. Most common ones don't.

https://www.enmicocinahoy.cl/un-clasico-pan-chileno-hallullas-a-chilean-bread/

I can always make another commit to remove the milk, if it's more true to life. You're the subject matter expert; your call.

[Svankensen]

Thanks! Worth mentioning that milk is optional? It is only used for "glazing"and making the bread look brown. Given that in the cataclysm milk can only be gotten from livestock, it may be a good idea to do without it.
EDIT: I see your recipe uses half milk instead of water. Most common ones don't.
https://www.enmicocinahoy.cl/un-clasico-pan-chileno-hallullas-a-chilean-bread/

I can always make another commit to remove the milk, if it's more true to life. You're the subject matter expert; your call.

I'm no baker, but I did ask my baker friend. It depends and it's an option either way. Both I guess? I wouldn't pressume to impose on you, you are doing the work. But if you want to differentiate, found this recipe for "european rustic lard bread" that is just lard, water, yeast, flour, salt and sugar.

http://www.2pots2cook.com/2020/04/16/rustic-lard-bread/

[ToxiClay]

There's probably a much simpler way to do this, but I just split hallula into two recipes, with the same name but different internal IDs. This surely won't snap anything in half.

[emptytriangle]

There's probably a much simpler way to do this, but I just split hallula into two recipes, with the same name but different internal IDs. This surely won't snap anything in half.

I think you want your "omitting milk from the recipe" patch but instead of

[ [ "milk_standard_raw", 1, "LIST" ] ],

you want

[ [ "milk_standard_raw", 1, "LIST" ], [ "water", 1 ] ],

That should let you choose whether to use 1 water or 1 milk for that line of the recipe. I don't know if this will work because you also have 1 water required on the next line. So, I do not know if the code will handle (1 milk, 1 water) vs (2 water). I know that it would handle (2 milk) vs (2 water) if water wasn't also on the next line.

I suspect if you did use 100% milk instead of water when making hallullas they would turn out just fine.

[jbytheway]

Using something like (1 milk, 1 water) vs (2 water) should now work; I added support for such requirements a few months ago (#36657).

[ToxiClay]

Is there a way to tie not using milk in the recipe to producing the hallula_without_milk item?

[jbytheway]

No, if you want different products you'll need separate recipes. We could move to make milk behave more like toxins, where the content of the product depends on the content of the ingredients, but that would be a larger change.

[emptytriangle]

what is the purpose of a hallula_without_milk item? There is no need for it. Just make one hallula item that can be cooked with either milk or water. The caloric content and vitamin content of the output will be based on the items used to cook it. There is no reason for it to be a different product just because you used milk instead of water.

[ToxiClay]

what is the purpose of a hallula_without_milk item? There is no need for it.

The purpose is to distinguish between the two. Refer up-thread to Svan mentioning how the milk browns the end product, and then refer to my changes where I mention that difference in the items.

[emptytriangle]

seems unnecessary to modify the description of the item just to say it's slightly brown when it causes such complication

[Maleclypse]

Sweet it looks like this only has one calorie test failure now so I think you should be able to make the same charges change to the other recipe and that will fix that :)

[ToxiClay]

Sweet it looks like this only has one calorie test failure now so I think you should be able to make the same charges change to the other recipe and that will fix that :)

Why did that cause the system to bug out and fail testing? I drew from the recipe I found online, so why does the compiler hate it?

[ToxiClay]

../tests/explosion_balance_test.cpp:95: FAILED:

Um. My bread should not be exploding.

[Maleclypse]

Thanks i'd say the explosion error is unrelated unless I'm super confused.

[Rivet-the-Zombie]

Am I missing something here? These two recipes look identical - the one that supposedly contains milk does not include milk in its components.

[ToxiClay]

I can't remember why I left this comment justifying the change.

"//2": "Since milk is only used sparingly in the creation of hallula, to give it a glazed appearance, Cataclysm practicality suggests omitting it."

I think I did this specifically to make a cosmetic distinction between the two, but since I can't for my life understand why I did that, I'll just kill the without_milk one.