-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New side story: Pizzaiolo #46101
Merged
ZhilkinSerg
merged 11 commits into
CleverRaven:master
from
El-Jekozo:new-unique-npc-pizzaiolo
Jan 25, 2021
Merged
New side story: Pizzaiolo #46101
ZhilkinSerg
merged 11 commits into
CleverRaven:master
from
El-Jekozo:new-unique-npc-pizzaiolo
Jan 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f4d579c.
anothersimulacrum
added
[JSON]
Changes (can be) made in JSON
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
labels
Dec 17, 2020
Maleclypse
reviewed
Dec 19, 2020
Co-authored-by: Maleclypse <[email protected]>
Maleclypse
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting storylines. Thanks!
Co-authored-by: Maleclypse <[email protected]>
Co-authored-by: Maleclypse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "New side story: Pizzaiolo"
Purpose of change
This PR adds new unique NPC - Pizzaiolo, that will spawn at restaurant with 50% probability. NPC has it's own mission line, where Pizzaiolo will ask player to join him in his path of revenge! After completing his mission line, NPC can be recruited to be a trusted follower.
Describe the solution
Added new NPC file, changed restaurant mapgen file to add npc spawn point, added trait for unique backstory for this char, updated backgrounds_table_of_contents, added backstory file, created new folder for "non-categorized" unique npcs.
Describe alternatives you've considered
Feedback is welcome on what should or may be additionally done/redone/tweaked/etc.
Some missions may be tweaked, dialogues rewrite, clothes/stats/traits/rewards/spawn point/etc may be changed as well.
NPC json may be placed somewhere else.
Testing
Spawned special, played the whole mission line and don't get any errors or missed stuff. Additional testing is appreciated.
Additional context
This PR copies talk topic and mapgen_update from #44999 PR. If that PR will be merged first, copy of that lines should be deleted in the end of npc json.