Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Lengthening #1 - Kitchen Tools & Knives #45186

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

Ciac32
Copy link
Contributor

@Ciac32 Ciac32 commented Oct 31, 2020

Summary

SUMMARY: Balance "Add lengths to non-clutter kitchen items"

Purpose of change

Add longest_side attribute to items that don't have one yet. This PR focuses on kitchen items and weaponry.

Describe the solution

Got all these item lengths off via comparing matching items on Amazon and averaging it out:

  • Rolling Pin: 45 cm
  • Pot & Copper Pot: 23 cm
  • Cast-Iron Pot: 24 cm
  • Casserole: 23 cm
  • Stock Pot: 25 cm
  • Canning Pot: 27 cm
  • Cast-Iron Pan: 36 cm
  • Steel & Copper Pan: 35 cm
  • Makeshift Pot & Copper Pot: 20 cm

Knives:

  • Butcher Knife: 35 cm
  • Steak Knife: 25 cm
  • Paring Knife: 15 cm
  • Chef Knife: 30 cm
  • Carving Knife: 30 cm
  • Bread Knife: 35 cm
  • Vegetable Cleaver: 30 cm
  • Meat Cleaver: 30 cm

Describe alternatives you've considered

Removing the concept of kitchens from the game

Testing

Nothing specific, but had it applied for a week during my usual gameplay and nothing broke.

Additional context

Powered appliances will have to come when I get around to those types of general tools

@mlangsdorf mlangsdorf added <Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact Items: Containers Things that hold other things labels Nov 1, 2020
@Ciac32 Ciac32 changed the title [WIP] The Lengthening #1 - Kitchen Tools & Knives The Lengthening #1 - Kitchen Tools & Knives Nov 11, 2020
@Ciac32
Copy link
Contributor Author

Ciac32 commented Nov 11, 2020

I don't really have any time to work on this for the next few weeks, so I'm gonna knock it out of WIP so the work I do have can get in. Hot plate & food processors will need to come later.

@Rivet-the-Zombie Rivet-the-Zombie merged commit b48a967 into CleverRaven:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items: Containers Things that hold other things Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants