Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Counter techniques have had a hack applied for years setting their move cost to 0 to avoid having the player stunlock themselves when countering.
See #15101
#25859
Describe the solution
Remove the hack and replace it with a guard that prevents a player from stun locking themselves with counters by not selecting a counter if using it would result in the character skipping their next turn.
Describe alternatives you've considered
Some of these counters probably deserve a move cost multiplier as per typical attacks of their style, but I'm not well versed enough in the styles to make that determination, so if that happens it needs to be in a follow up PR.
Testing
Spawn a skilled character with a martial art that grants a counter and hang out near some attacking enemies. Player should be able to act every turn and occasionally fire off counters.
Do the same but with a character with impaired speed.