Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP [ Magiclysm ] Necromancer Sheath Bugfix #42614

Merged
merged 5 commits into from
Aug 3, 2020

Conversation

Maleclypse
Copy link
Member

Summary

SUMMARY: Bugfixes "Adds sheath entry to necromancer profession"

Purpose of change

Fixes #42117

Describe the solution

Adds a sheath entry containing the primitive knife. Adds a belt item to attach sheath to.

Describe alternatives you've considered

Testing

Additional context

@meladath
Copy link
Contributor

meladath commented Aug 1, 2020

I believe you are missing a comma at the end of line 192.

@KorGgenT
Copy link
Member

KorGgenT commented Aug 2, 2020

image

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) Items: Containers Things that hold other things Mods: Magiclysm Anything to do with the Magiclysm mod labels Aug 3, 2020
@Maleclypse Maleclypse changed the title [ Magiclysm ] Necromancer Sheath Bugfix WIP [ Magiclysm ] Necromancer Sheath Bugfix Aug 3, 2020
@Maleclypse
Copy link
Member Author

I'll load this into my magiclysm test tonight.

@KorGgenT
Copy link
Member

KorGgenT commented Aug 3, 2020

all the checks are passing so i'm going to load it up some time in the next couple hours.

@KorGgenT KorGgenT closed this Aug 3, 2020
@KorGgenT KorGgenT reopened this Aug 3, 2020
@KorGgenT KorGgenT merged commit 929da56 into CleverRaven:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items: Containers Things that hold other things Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Magiclysm) Novice Necromancer and the stone knife fix
4 participants