fix deleting items on insert #41556
Merged
fix deleting items on insert #41556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[C++]
|
Should probably resolve most of #41551 too |
|
I don't think it will- this addresses the player using the menu to insert |
|
Yes, my bad - it is a different thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "fix deleting items on insert"Purpose of change
Fixes #41536
Describe the solution
change the call from item to its contents directly. item::can_contain checks if rigid contained items, which is problematic for the inventory screen, which should only check the top level contents can contain it.
Testing
follow the instructions in the attached issue, see that the item doesn't show in insert screen