Add magazine wells to items #40668
Add magazine wells to items #40668
Conversation
ymber
added
[JSON]
|
I haven't had a chance to review it yet, but this probably addresses the comment i made in #40399 |
There was a problem hiding this comment.
This is the only error related to your changes, which makes sense that it was an error due to the script.
There are technically errors with the following, but they appear to be because the magazine is not watertight, and unrelated directly with this PR.
chemical_thrower
flamethrower_crude
watercannon
Also note: This PR is codependent on #40399 and if it is merged alone it will break gun json
Co-authored-by: Curtis Merrill <[email protected]>
Co-authored-by: Curtis Merrill <[email protected]>
data/json/items/gun/38.json
Outdated
| "holster": true, | ||
| "max_contains_volume": "20 L", | ||
| "max_contains_weight": "20 kg", | ||
| "item_restriction": [ "38_speedloader6" ] |
There was a problem hiding this comment.
so all of the guns with integral magazines that can be used with speedloaders should still have an integral magazine, not a magazine well - in the reloading code it just allows you to use a speedloader to put the ammo into the gun, so it should be a MAGAZINE type
ghost
mentioned this pull request
Summary
SUMMARY: Infrastructure "Add mag wells to all relevant items"
Purpose of change
#40399 needed it.
Describe the solution
Add
MAGAZINE_WELLtype pockets to relevant items.Describe alternatives you've considered
Setting appropriate maximum values for volume and weight.
Testing
Won't work without changes in #40399.