Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to survivor harness "pocket" weight capacity #40485

Merged
merged 4 commits into from
May 13, 2020

Conversation

grimmspector
Copy link
Contributor

@grimmspector grimmspector commented May 12, 2020

Summary

SUMMARY: Content "Update to survivor harness 'pocket' weight capacity"

Purpose of change

Update the survivor harness pocket volume for new nested inventory system, initial given weight capacity doesn't allow use with any rifle despite it being the purpose of the clothing.

Describe the solution

Weight capacity for this makes no sense, as it cannot hold the items it's intended to hold. Review of many similar devices (tactical harnesses, clips, etc.), indicates they mostly handle rifles up to and around AR-15s. Current game weight of AR-15 is 7.72 kg, versus harnesses capacity of 2.0 kg. Suggest additional weight of optics and such, and that other similarly sized weapons should fit, but not long rifles like sniper rifles. Propose 8.20 kg capacity as given in commit.

Most similar devices are made of nylon and like materials. However, survivor harness leather should be easily capable of the same weights. Encumbrance should be examined and is being corrected separately by someone else. It may also be worth reviewing max volume, though some rifles may have incorrect high volumes.

Edit: After discussion in comments, updated volume to 8 L to meet modern rifle volumes included in game.

Describe alternatives you've considered

Letting someone else figure it out.

Testing

Loaded in game.

Additional context

Example of such devices:


Weight capacity for this makes no sense, as it cannot hold the items it's intended to hold. Review of many similar devices (tactical harnesses, clips, etc.), indicates they mostly handle rifles up to and around AR-15s. Current game weight of AR-15 is 7.72 kg, versus harnesses capacity of 2.0 kg. Suggest additional weight of optics and such, and that other similarly sized weapons should fit, but not long rifles like sniper rifles. Propose 8.20 kg capacity as given in commit.

Most similar devices are made of nylon and like materials. However, survivor harness leather should be easily capable of the same weights. Encumbrance should be examined and is being corrected separately by someone else. It may also be worth reviewing max volume, though some rifles may have incorrect high volumes.

Example of such devices:
https://www.aliexpress.com/item/32833554451.html

https://www.defensereview.com/p2-systems-maniple-i-tactical-armor-carrier-system-for-special-operations-video/

https://www.worthpoint.com/worthopedia/airsoft-tactical-sling-qry03-osprey-489768432
@ghost
Copy link

ghost commented May 12, 2020

You can bump the max volume up too, the back holster has 9L/10kg pocket limits

@grimmspector
Copy link
Contributor Author

You can bump the max volume up too, the back holster has 9L/10kg pocket limits

I'm not sure of a good suggestion for volume at the moment, but I'd think double would be fine based on the guns, though most guns aren't actually that big in the item browser. Any suggestion?

@curstwist curstwist added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels May 12, 2020
@ghost
Copy link

ghost commented May 12, 2020

I haven't gotten to a lot of longguns yet, the FS2000 is 7986ml(#36838) irl so it's not unreasonable.

Modify the volume to meet rifles like the FS2000 real world volumes.
@Rivet-the-Zombie Rivet-the-Zombie merged commit 5a77b23 into CleverRaven:master May 13, 2020
fengjixuchui added a commit to fengjixuchui/Cataclysm-DDA that referenced this pull request May 13, 2020
Merge pull request CleverRaven#40485 from grimmspector/survivor-harness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants