Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove control laptop from vanilla and move it to Aftershock mod #40423

Merged
merged 2 commits into from
May 12, 2020

Conversation

ymber
Copy link
Member

@ymber ymber commented May 10, 2020

Summary

SUMMARY: Content "Remove control laptop"

Purpose of change

The control laptop is a cheap exploit.

Describe the solution

Obsolete control laptop.

Testing

Game loads. Control laptop is gone.

Additional context

This should come back at some point in the future when #39454 and further work in that direction can make it work in a reasonable way.

@ymber ymber added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map labels May 10, 2020
@Sumguy62
Copy link
Contributor

I'm sure that a lot of people would prefer if there were some actual replacement for some of the functionality of the control laptop before you remove it.

@anothersimulacrum
Copy link
Member

This has been problematic for months, if not years, and nobody has added anything in that intervening time, so I don't think that should be a blocker for this change. If this change inspires someone to go fix it, great, but seeing as nobody has stepped up to the plate it's pointless to wait for it.

Furthermore, this entire current function is problematic. There's no magical software that makes it so that with enough skill, and a little bit of time, you can bypass the security of every single robot.

@John-Candlebury
Copy link
Member

You willing to save me a PR and move it to aftershock?

I do kinda want it in there.

@Night-Pryanik Night-Pryanik changed the title Remove control laptop Remove control laptop from vanilla and move it to Aftershock mod May 11, 2020
@kevingranade kevingranade merged commit 2f41b8b into CleverRaven:master May 12, 2020
@ymber ymber deleted the control_laptop branch May 12, 2020 05:59
@Solusphere
Copy link

The thing that makes me most sad about this is that it removes the only reliable way of rescuing Prototype Cyborgs.

@anothersimulacrum
Copy link
Member

It doesn't, use scramblers.

@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/best-method-to-find-out-reason-for-a-commit/23706/2

@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/cant-find-any-usbs-with-software/23970/4

@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/cant-find-any-usbs-with-software/23970/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants