-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CR][WIP] Add effect tests #40064
Closed
Closed
[CR][WIP] Add effect tests #40064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
added
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
Code: Tests
Measurement, self-control, statistics, balancing.
labels
May 2, 2020
This takes around 10 seconds to run, and may be fragile even with this generous margin for error.
Still not reliable; tagged with [!mayfail]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
Code: Tests
Measurement, self-control, statistics, balancing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Add tests for effects on creature and player"
Purpose of change
To have some tests on effects, how they work, and how they are applied to creatures / characters / monsters / players.
Describe the solution
Adds new tests (many still in progress or planned):
tests/effect_test.cpp
tests/creature_effect_test.cpp
tests/player_effect_tests.cpp
Describe alternatives you've considered
Tests without effects
Testing
tests/cata_test [effect]
Additional context
Work in progress. This is becoming much more in-depth and sizable than I originally planned, so I may break off the player hardcoded effect tests (the least complete, and least reliable of the bunch) into a separate PR.
Comments and suggestions are welcome; I am learning the effects system and documenting it as I go, and would prefer to avoid adding false or misleading information.