Migrate ACT_OPEN_GATE to the activity actor system #40039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per issue CleverRaven#40013 the goal is to migrate all activities from activity_handlers.cpp to the new activity actor system references CleverRaven#40013
ifreund
reviewed
May 1, 2020
ifreund
reviewed
May 1, 2020
ifreund
added
[C++]
Remove unnecessary setting of `act.placement` Co-authored-by: Isaac Freund <[email protected]>
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Migrate ACT_OPEN_GATE to the activity actor system."
Purpose of change
Per issue #40013 the goal is to migrate all activities from activity_handlers.cpp to the new activity system added in #37450.
Testing
All tests from test suite passed locally. Also tried opening gates/doors in game.