Enum classes

[ZhilkinSerg]

Summary

SUMMARY: None

Purpose of change

Add class to some enums (rename enum class members in the process, to remove prefixes)

Describe alternatives you've considered

Leave enums alone in a classless society.

Testing

Let it compile.

[jbytheway]

It would be good to remove the (now-unnecessary) common prefix from the enumerator names.

If you don't want to do that by hand, then I had a plan to implement a clang-tidy check to do it at some point.

[anothersimulacrum]

I introduce a new enumeration in #39387 should I convert it to an enum class as well?

[kevingranade]

Yes, I want to discuss with everyone, but I think this would be a good thing to make mandatory.

…

On Sun, Apr 12, 2020, 7:19 PM anothersimulacrum ***@***.***> wrote: I introduce a new enumeration in #39387 <#39387> should I convert it to an enum class as well? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#39510 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGSA5D5NZQ34YJMUNWMKBLRMJZCJANCNFSM4MGSYFTQ> .

[ZhilkinSerg]

I introduce a new enumeration in #39387 should I convert it to an enum class as well?

Yes, it should not be any harder to use than plain enums in most cases.

It would be good to remove the (now-unnecessary) common prefix from the enumerator names.

If you don't want to do that by hand, then I had a plan to implement a clang-tidy check to do it at some point.

I was thinking about renaming them too. Will do.

[jbytheway]

Yes, I want to discuss with everyone, but I think this would be a good thing to make mandatory.

Agreed, I think it should be the default to do so, unless some unusual situation dictates otherwise. Certainly for enums at global scope.