Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasteland sausage recipe smoked from raw wasteland sausage #39055

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Fix wasteland sausage recipe smoked from raw wasteland sausage #39055

merged 1 commit into from
Mar 27, 2020

Conversation

KurzedMetal
Copy link
Contributor

@KurzedMetal KurzedMetal commented Mar 27, 2020

Summary

SUMMARY: Bugfixes "Fix wasteland sausage recipe smoked from raw wasteland sausage"

Purpose of change

Wasteland sausage recipe from raw wasteland sausage consumes x2 recipe
time but use x5 less Charcoal than than crafting directly from components.
Also, even tho nutrition total output match, it outputs x2 more units with 1/2 nutrition each,
making enjoy and quench penalty be twice as worse.
I don't see a reason why two-step cooking should be so different, I'm pretty sure
it was an error when copy-pasteing from the original recipe when the recipe was first created in #37316
I fixed the recipe so both have similar time, component requirements and output.
Making raw wasteland sausage first is still slightly slower process due to having to prepare it raw first.

EDIT: I also just noticed from the images that the output also took x2 volume as it generated x2 more units with 1/2 nutrition.

Describe the solution

  • Halved time to prepare to match recipe from components, it is still slightly slower to cook from raw wasteland sausage, due to the time it takes to make prepare them.
  • Reduced the recipe "charges" from 2 to 1: now the output kcal/nutrition from "raw" recipe match with the output from components. EDIT: Also fix the volume mismatch.
  • increased batch time reductions requriements from 3 units to 6 units, so the reduction in both recipes happen at the same volume/quantity output.
  • increased charcoal consumption on the "raw" recipe from 1 to 5 to match the other recipe too.

Describe alternatives you've considered

None

Testing

I compiled the code with latest master brand locally and tested the change

Some images from my tests showing before/after PR changes...

  • keep in mind that I use x5 batch in one recipe and x10 batch in the other recipe because one generates 1 sausage per batch (or at least it should), and the other one 2 sausages per batch.
  • so focus mostly in how affect the output count (and how it would affect enjoyment), kcal/nutrition, charcoal and time consumptions.
  • keep in mind that preparing 10 units of raw wasteland sausage takes 35 mins (so the new recipe from "raw" takes a total of 2h 42m)

Recipe from Components as reference (this recipe wasn't changed):

image

Recipe from "raw", before this change

image

Recipe from "raw", After this change

image

Wasteland sausage recipe from raw wasteland sausage consumes x2 recipe
time but use x5 less Charcoal than than crafting directly from components.
Also, even tho nutrition output match, it outputs x2 more units with 1/2 nutrition,
making enjoy penalty be twice as worse.
I don't see a reason why two-step cooking should be so different, I'm pretty sure
it was probably an error when copy-pasteing from the original recipe.
I fixed the recipe so both have similar time, component requirements and output.
Making raw wasteland sausage first is still slightly slower process due to having to prepare it raw first.
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Mar 27, 2020
@ZhilkinSerg ZhilkinSerg merged commit 62af47d into CleverRaven:master Mar 27, 2020
@KurzedMetal KurzedMetal deleted the fix-wasteland-sausage-from-raw-recipe branch March 27, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants