Fix tidy-up activity not working for NPCs #38504
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix tidy-up activity not working for NPCs"
Purpose of change
Fix tidy-up activity not working for NPCs
Describe the solution
This was fixed in one of my NPC activity PRs in feature freeze, but I may as well split the fix out because its stopping me testing other stuff.
In the activity loop, tidying up items dosnt work because of a misplaced edit to the if/else structure branch, overwriting the list of locations.
Describe alternatives you've considered
N/A
Testing
Before : NPC did work, left things lying everywhere.
after : NPC tidies up activity items to an unsorted spot, as intended.
Additional context
N/A