Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tidy-up activity not working for NPCs #38504

Merged
merged 1 commit into from Mar 2, 2020
Merged

Fix tidy-up activity not working for NPCs #38504

merged 1 commit into from Mar 2, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 1, 2020

Summary

SUMMARY: Bugfixes "Fix tidy-up activity not working for NPCs"

Purpose of change

Fix tidy-up activity not working for NPCs

Describe the solution

This was fixed in one of my NPC activity PRs in feature freeze, but I may as well split the fix out because its stopping me testing other stuff.
In the activity loop, tidying up items dosnt work because of a misplaced edit to the if/else structure branch, overwriting the list of locations.

Describe alternatives you've considered

N/A

Testing

Before : NPC did work, left things lying everywhere.
after : NPC tidies up activity items to an unsorted spot, as intended.

Additional context

N/A

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Mar 2, 2020
@ZhilkinSerg ZhilkinSerg merged commit 1646380 into CleverRaven:master Mar 2, 2020
@Funguss
Copy link
Contributor

Funguss commented Mar 2, 2020

Ah, so there was a bug! I've been wracking my brains for days trying to figure out how I'm messing up loot zones and getting incredibly frustrated. Thanks so much for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants