traps can cast spells #38122
Merged
traps can cast spells #38122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[JSON]
|
That is brilliant! Keep up the bear related humour! Also, nice feature. 👍 |
|
I'm not familiar with summoning effect. Are summoned monsters friendly? |
BevapDin
reviewed
Feb 19, 2020
these aren't, due to the HOSTILE_SUMMON flag, and they should not be by default because the trap passes basically a temporary brand new |
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 15, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 15, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 16, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 17, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 17, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 18, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 29, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 1, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 1, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 2, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "traps can cast spells"Purpose of change
make traps able to cast spells!
Describe the solution
create a trapfunc called cast_spell and adds a fake_spell object to trap. creates a new trap that summons bears, called "bear trap". i didn't spawn it anywhere yet but i'm sure it can go in future areas.
Testing
used the map editor to spawn in a bear trap. walk over it and summon 3 bears.