Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nopalitos recipe #37857

Merged
merged 2 commits into from
Feb 9, 2020
Merged

Fix Nopalitos recipe #37857

merged 2 commits into from
Feb 9, 2020

Conversation

jkraybill
Copy link
Contributor

Summary

SUMMARY: Content "Fix Nopalitos recipe"

Purpose of change

Fixes #37837 and makes some changes to have the recipe make more sense.

#37837 was caused by Nopalitos not having the "comestible_type" flag correctly set.

When I went in to look, I found some other issues with this recipe that I fixed.

Describe the solution

The caloric content of cactus pads was WAY too high -- it was previously 100 calories per cup, which would give one cup of nopalitos that had 300 calories. Based on a calorie counter (https://www.nutritionix.com/i/nutritionix/nopalitos-1-cup/5824ef736162ad862e912a9d) 1 cup of nopalitos should have more like 22 calories.

I opted to adjust the recipe so that 3 cups of cactus pads makes 2 cups of nopalitos, so I adjusted the calories and vitamins of cactus pads to be 2/3 of the nopalitos, so 1 cup of pads now has 15 calories and nopalitos have 45 calories in a 2-cup portion.

I also added a batch factor to nopalitos such that they get 80% time savings at >4 batches, which seems realistic. I adjusted down the recipe time based on this recipe which cites 20-25 minutes: https://40aprons.com/how-to-cook-nopales-cactus/

Describe alternatives you've considered

I could have just added the comestible_type flag to fix the symptom from #37837 but then I would have had to ignore the incorrect caloric content and recipe ratios.

Testing

I replicated this problem on the main branch, and verified it was fixed by adding the comestible_type flag. Then I crafted nopalitos and spawned some pre-made nopalitos and compared their nutritional content. Also tested batch crafting before and after.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks labels Feb 9, 2020
@ZhilkinSerg ZhilkinSerg merged commit 9e9ad73 into CleverRaven:master Feb 9, 2020
@jkraybill jkraybill deleted the 37837 branch February 9, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nopalito not working
2 participants